Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANCHOR-752][ANCHOR-783] Make amount_out optional for request funds #937

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

philipliu
Copy link
Contributor

No description provided.

@philipliu philipliu marked this pull request as ready for review August 22, 2024 18:36
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

@philipliu philipliu force-pushed the anchor-752-remove-amount-out-2 branch from f2b804d to 3111142 Compare August 23, 2024 01:24
@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

@lijamie98
Copy link
Contributor

Is there a Jira ticket related to this?

@philipliu
Copy link
Contributor Author

This adds docs for ANCHOR-752 and ANCHOR-783.

@lijamie98
Copy link
Contributor

lijamie98 commented Aug 26, 2024

This adds docs for ANCHOR-752 and ANCHOR-783.

Can we add ANCHOR-752 and ANCHOR-783 tags to the title of the PR?

@philipliu philipliu changed the title [AP] Make amount_out optional for request funds [ANCHOR-752][ANCHOR-783] Make amount_out optional for request funds Aug 26, 2024
@philipliu philipliu merged commit 0244259 into stellar:main Aug 26, 2024
2 checks passed
lijamie98 pushed a commit to lijamie98/stellar-docs that referenced this pull request Aug 26, 2024
…stellar#937)

* [AP] Make `amount_out` optional for request funds

* Make amount_out optional in offchain as well

* Revert "Make amount_out optional in offchain as well"

This reverts commit e00390f.

* Make amount_out optional in offchain as well

* Remove empty space
janewang pushed a commit that referenced this pull request Sep 12, 2024
…#937)

* [AP] Make `amount_out` optional for request funds

* Make amount_out optional in offchain as well

* Revert "Make amount_out optional in offchain as well"

This reverts commit e00390f.

* Make amount_out optional in offchain as well

* Remove empty space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants