[Wallet SDK] Port useful changes from MGI guide to the generic Sep-24 guide #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is available here: |
piyalbasu
reviewed
Aug 21, 2024
| @@ -542,6 +701,12 @@ final paymentResult = await sdk.submitTransaction(transaction); | |||
|
|
|||
| Where `keypair` is the SEP-10 authenticated account. If you want to transfer funds from a different address, refer to [Changing Stellar Transfer Account](#changing-stellar-transfer-account) section. | |||
|
|
|||
| Code for submitting transactions to Stellar should be developed thoughtfully. The SDF has a documentation page dedicated to [submitting transactions and handling errors gracefully]. Here are a few things you need to keep in mind: | |||
There was a problem hiding this comment.
piyalbasu
approved these changes
Aug 21, 2024
| val transaction = sep24.getTransactionBy(authToken, id = "transaction id") | ||
|
|
||
| // "stellarTransactionId" (aka "stellar_transaction_id" on the SEP spec) | ||
| // is the hash of the Stellar network transaction payment related to this |
There was a problem hiding this comment.
Would it make sense to expand on "is the hash of the Stellar network transaction payment"?
Do we think the reader assumes sha256 already or should we add a snippet?
There was a problem hiding this comment.
@aristidesstaffieri good point, I've added a change here: fd92a20
let me know what you think - thanks!
aristidesstaffieri
approved these changes
Aug 21, 2024
|
Preview is available here: |
janewang
pushed a commit
that referenced
this pull request
Sep 12, 2024
… guide (#930) * Consolidate 'token' => 'authToken' in all places * Fix typos * Port useful changes from MGI guide to this Sep-24 guide * Expand on stellar id hash format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports some useful changes from Integrate with MoneyGram Access specific guide to the generic Hosted Deposit and Withdrawal guide.
This PR also fixes some small
typosand consolidate the variable nametokento beauthToken(since a few places were usingtokenand other places were usingauthTokenfor the same thing).Preview is available here (most of the changes are on the
Typescripttab): https://developers-pr930.previews.kube001.services.stellar-ops.com/docs/build/apps/wallet/sep24