-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds wallet sdk docs for sep7 #926
Conversation
Preview is available here: |
@aristidesstaffieri I think the content from this PR is great, but I noticed it's mostly exploring only the part of parsing a given existing string to a There is this other positive aspect of the SDK which is creating those Sep7 objects using the existing getters and setters of the Sep7 class, so devs don't need to worry about decoding/encoding stuff. Like the below:
There is also the What do you think? |
…uri before instantiation
Yeah totally, I could expand on using a few setters for each operation. I'll show the signature helpers as well. 👍 |
Preview is available here: |
|
Preview is available here: |
@aristidesstaffieri looks good, thanks for the changes :) I left a few comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Preview is available here: |
* adds wallet sdk docs for sep7 * adds asset code and issuer to payment op, uses parseSep7Uri to parse uri before instantiation * adds examples of parameter setters and examples for addSignature and verifySignature * tweaks params and fixes typo
Adds docs and walkthrough for wallet-sdk sep7 classes.
Adds examples of how to use the tx and pay operations.