[ANCHOR-704] Clean up amount_fee and document user_action_required_by
#910
Conversation
|
Preview is available here: |
|
Looks good from what I can tell after a quick look. Just want to make sure, though, this is still needed for |
| amount_fee: | ||
| $ref: '#/components/schemas/Amount' | ||
| fee_details: | ||
| $ref: '#/components/schemas/FeeDetails' |
There was a problem hiding this comment.
Did we remove amount_fee from the response we return? I think it should still be there to avoid breaking wallets that still use it. It should just always equal fee.total
There was a problem hiding this comment.
This is platform response, not sep response. We don't have openapi spec for SEP responses (though IMO we should)
For wallets yes amount_fee is still there.
Even in platform amount_fee is still there, just deprecated. We always remove deprecated fields from docs
There was a problem hiding this comment.
amount_fee is removed in 3.0 https://stellarorg.atlassian.net/browse/ANCHOR-636 as breaking change
edit from Gleb: removed from platform transaction, not from sep transaction
| `SEP24_INITIAL_USER_DEADLINE_SECONDS` is the time in seconds a user has to act before the transaction automatically moves to the next status. It determines the `user_action_required_by` field, which indicates the deadline for statuses with automatic movement. Check [JSON-RPC Methods][json-rpc-methods] for usage examples. | ||
|
|
There was a problem hiding this comment.
I must have missed the PR implementing user_action_required_by so I'm missing context, but why do we have a configurable default value for this? Wouldn't the time the user has to act be highly dependent on the specific situation? I would've thought we would always require the business to set the time in each RPC request.
Also when you say "automatically moves to the next status", the business still has to make an RPC request to move the transaction to the next status right? The anchor platform doesn't monitor the time and move the transaction status on its own.
There was a problem hiding this comment.
but why do we have a configurable default value for this
When we create transaction and it's in incomplete status, we might want to set an expiration time right from the start. This is the "default" value (probably better to name it "starting" value)
The anchor platform doesn't monitor the time and move the transaction status on its own.
This is correct @JiahuiWho business needs to monitor expiration time for transaction on their own. They should use GET /transactions and can order_by user_action_required_by field
There was a problem hiding this comment.
Do you min adding an example of GET /transactions usage?
Yes, I asked Jiahui to wait a bit with this PR to not mess up your reorganizing PR 🙏🏼 |
|
Something went wrong with PR preview build please check |
|
Preview is available here: |
|
Hi, @JiahuiWho! #909 is now merged, so you should be ready to get this ready now. Two things you'll probably want to note:
|
|
@JiahuiWho we probably want to start this PR fresh off the current main branch |
|
Preview is available here: |
This is a resubmit of #857 due to rebase
NotifyInteractiveFlowCompletedRequest
NotifyTransactionOnHoldRequest
NotifyOffchainFundsPendingRequest
NotifyOffchainFundsAvailableRequest
RequestCustomerInfoUpdateRequest
RequestOffchainFundsRequest
RequestOnchainFundsRequest
RequestTrustRequest
platforms/anchor-platform/admin-guide/sep6/configuration.mdx
platforms/anchor-platform/admin-guide/sep24/configuration.mdx