-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy a Stellar Asset Contract (SAC) for a Stellar asset using code #887
Conversation
git add .
@briwylde08 this is ready for review. |
Thank you! We'll get this assigned and reviewed! |
Stellar Asset Contract deployed as expected https://stellar.expert/explorer/testnet/contract/CBF2X6JDA5BRMITM5VIHACY6YVWX2NRJQ7YN7EN3KXHXWWX66Z3DSMFU |
Hi @anataliocs , Thank you for the feedbacks.
|
Hello @briwylde08 @anataliocs , just checking in for the status of the review. |
Hi @KodeSage! Sorry for the delay! @anataliocs is out of town but will get to the re-review asap! |
HI @briwylde08 @anataliocs , just checking in again for the status of the review. |
Hi @KodeSage!! Sorry for the delay here, will get this reviewed asap. Thank you for the flag! |
alright thank you @briwylde08 |
@KodeSage Doing a final review now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @anataliocs 🚀 |
Thanks again for your contribution @KodeSage! We'll take the award conversation back to the corresponding issue. |
…887) * chores: initialization of SAC using code * chores: added code walk through * chores: code explanation git add . * chores: final code explaination * editorial * chores: updated code nitpicks * chores: editorial fix * Update docs/build/guides/conventions/deploy-sac-with-code.mdx * Update docs/build/guides/conventions/deploy-sac-with-code.mdx --------- Co-authored-by: Bri <[email protected]> Co-authored-by: Chris Anatalio <[email protected]>
Bounty PR closes #615