Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fully-typed-contracts.mdx #823

Merged
merged 12 commits into from
Aug 20, 2024
Merged

Update fully-typed-contracts.mdx #823

merged 12 commits into from
Aug 20, 2024

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Jul 24, 2024

This document was quite out-of-date. I've updated what I know about off the top of my head, but I'm not sure how to update all of it.

This document was quite out-of-date. I've updated what I know about off the top of my head, but I'm not sure how to update all of it.
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@briwylde08
Copy link
Contributor

I'm not sure why the build is failing. I've yarn format:mdx'd and yarn build'd successfully /shrug

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

Copy link
Contributor

@ElliotFriend ElliotFriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for updating this @chadoh!! Left a few minor nitpicks here-and-there.

@stellar-jenkins
Copy link

@ElliotFriend
Copy link
Contributor

I think I finally got the weird thing in the path-payment.mdx file figured out (i've seen it get (re-)formatted back and forth a few times recently). Hopefully it sticks this time 🤞🏻

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@briwylde08 briwylde08 merged commit 6dbe044 into stellar:main Aug 20, 2024
2 checks passed
janewang pushed a commit that referenced this pull request Sep 12, 2024
* update fully-typed-contracts.mdx

This document was quite out-of-date. I've updated what I know about off the top of my head, but I'm not sure how to update all of it.

* formatting, couple nits

* Update docs/learn/encyclopedia/contract-development/types/fully-typed-contracts.mdx

Co-authored-by: Chad Ostrowski <[email protected]>

* remove outdated paragraph

* fix highlighting and indenting in path payment tutorial

* Update docs/learn/encyclopedia/contract-development/types/fully-typed-contracts.mdx

Co-authored-by: Elliot Voris <[email protected]>

* Update docs/learn/encyclopedia/contract-development/types/fully-typed-contracts.mdx

Co-authored-by: Elliot Voris <[email protected]>

* Update docs/learn/encyclopedia/contract-development/types/fully-typed-contracts.mdx

Co-authored-by: Elliot Voris <[email protected]>

* fix last update

* move it up

* Update docs/learn/encyclopedia/contract-development/types/fully-typed-contracts.mdx

Co-authored-by: Elliot Voris <[email protected]>

---------

Co-authored-by: Bri <[email protected]>
Co-authored-by: Elliot Voris <[email protected]>
Co-authored-by: Elliot Voris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants