Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: guide for extending a deployed contract's Wasm code TTL #812

Closed
wants to merge 3 commits into from
Closed

doc: guide for extending a deployed contract's Wasm code TTL #812

wants to merge 3 commits into from

Conversation

Mystic-Nayy
Copy link

resolves #618

@briwylde08
Copy link
Contributor

briwylde08 commented Jul 23, 2024

Thank you for your submission @Gift-Naomi! We'll get this assigned and reviewed and let you know any feedback!

@Mystic-Nayy
Copy link
Author

@briwylde08 Alright, I will be waiting.

@ElliotFriend
Copy link
Contributor

Hi, @Gift-Naomi! Thanks for participating in our docs bounty!

I'm a little unsure how to start reviewing your contribution. There's a few things you'll need to address before we really can get into reviewing this.

  1. You're replaced this existing guide, but we're looking to have a new guide created instead. Probably a new file in the /docs/build/guides/archival directory would fit best.
  2. It looks like you're writing in a way that could generically apply to several blockchains. I see references to substrate, polkadot, ink, etc. but no mention of Stellar and/or Soroban. We're wanting these guides to be written in a that's targeted and specific to Stellar.
  3. Based on the example contract you've provided here, it seems like you might be misunderstanding some of what we mean when we say TTL. Check out the State Archival docs to get a better handle on it. Particularly, the terms and semantics section might be useful for a quick overview.

Do those points make sense? If you have any questions, I'm more than happy to help get things unblocked for you.

Thanks again!

@Mystic-Nayy
Copy link
Author

@ElliotFriend
This guide includes both a code walkthrough and written explanations to help users understand how to extend the TTL of a deployed Wasm contract on Stellar. Let me know if you need any adjustments!

@Myestery
Copy link
Contributor

@Gift-Naomi please take a look at https://github.com/stellar/soroban-examples/tree/main/ttl/src
TTL logic is exemplified there

@Myestery
Copy link
Contributor

@briwylde08
Copy link
Contributor

Hi there @Gift-Naomi - we appreciate your effort and participation in the bounty. However, this doesn't quite solve for the ask in the corresponding bounty issue. We are looking for code examples for the task instead of CLI work and the contract code provided in this PR doesn't extend the contract's TTL. Again, we do appreciate the time and effort put into the bounty. If you have any questions, don't hesitate to ask.

All the best,
Bri

@briwylde08 briwylde08 closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a guide for extending a deployed contract’s Wasm code TTL with code
4 participants