Initial phase1 settings #4084
Merged
Initial phase1 settings #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
reviewed
Dec 6, 2023
dmkozh
reviewed
Dec 12, 2023
| auto& params = entry.current() | ||
| .data.configSetting() | ||
| .contractCostParamsCpuInsns(); | ||
| for (auto val : vals) |
There was a problem hiding this comment.
Instead of hardcoding the values here we should probably read the json instead. This is both less cumbersome and more safe. Fine to do as a followup though.
|
r+ 74cf669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4066 as well
Marked as draft because the cost types need to be updated.