soroban-rpc: Ingest temp ledger entry evictions #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am confused. Doesn’t this duplicate #925 ? |
|
Also, I am missing a test. |
yes, I worked on this during the morning as a follow up to stellar/go#5037 while not realizing that you were working on the same thing in #925 .
I will probably take the test from #925 😄 |
tsachiherman
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In stellar/go#5037 temporary ledger entries which are evicted are excluded from the change reader. So, we need to handle the deletions explicitly by the EvictedTemporaryLedgerKeys() method on the LedgerCloseMeta struct.
Known limitations
We aren't able to test eviction of temporary ledger keys through an integration test because stellar-core needs to implement a testing flag to allow evictions to occur more quickly. So instead I have implemented a unit test where I have hard coded a ledger which contains temporary ledger entry evictions.