Generate windows installer.

[fnando]

What

Create installer for Windows.

Why

This is a first step on making stellar-cli available on winget.

Known limitations

N/A

[leighmcculloch]

Very nice 👏🏻. One ask otherwise lgtm.

[leighmcculloch]

Three more questions.

Did the design folks provide the ico? Looks like the stellar.ico is a white on black icon. It's more common for the black on white icon to be used, so we should probably use it, or check in with the design folks.

The EnVar plugin is embedded as a binary and binaries are always a risk. Given the cli handles keys, we should be particularly careful about embedding the binary especially if we haven't built it from source ourselves. Even if we have built it ourselves isn't great. What do we need EnVar for? Can we get away without it?

The license for EnVar looks custom, or maybe based off the zlib/libpng licenses. The license looks straightforward to me personally, but we need the legal team to approve it before embedding.

[fnando]

Did the design folks provide the ico?

Didn't run this by them, but I've switched to white bg with black foreground. The icon's quality is super low, so it doesn't really matter (without it, it's just a blue square).

The EnVar plugin is embedded as a binary and binaries are always a risk. Can we get away without it?

We can't (or at least, shouldn't). That's the recommended way. Trying to manually handle the PATH can lead to the path being truncated/corrupted (as stated in their docs).

The license for EnVar looks custom, or maybe based off the zlib/libpng licenses. The license looks straightforward to me personally, but we need the legal team to approve it before embedding.

I'll run this by them.

[fnando]

@leighmcculloch this is good to go! Just tested this installer and it worked! 🎉

[leighmcculloch]

One suggestion, regardless lgtm. 👏🏻