Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/invoke view only #1697

Merged
merged 14 commits into from
Nov 13, 2024
Merged

Fix/invoke view only #1697

merged 14 commits into from
Nov 13, 2024

Conversation

elizabethengelman
Copy link
Contributor

@elizabethengelman elizabethengelman commented Nov 1, 2024

What

This allows users to invoke a contract with a view-only transaction to use a default account instead of erroring if the account doesn't exist on the passed network.

Closes #1454

Why

Currently in the CLI, if you pass the --help flag for example, but pass an account that doesn't exist on the configured network, you would see an error. With this change, you will not see an error, just the help menu.

Known limitations

n/a

@elizabethengelman elizabethengelman force-pushed the fix/invoke-view-only branch 2 times, most recently from 24b41b5 to 0eb337b Compare November 4, 2024 19:43
@elizabethengelman elizabethengelman marked this pull request as ready for review November 7, 2024 21:39
Copy link
Member

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me to move the send check to after parsing the arguments!

@elizabethengelman elizabethengelman merged commit 02c9c8e into main Nov 13, 2024
28 of 30 checks passed
@elizabethengelman elizabethengelman deleted the fix/invoke-view-only branch November 13, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

contract invoke: should not error when account does not exist for view-only or --help
2 participants