-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/invoke view only #1697
Merged
Merged
Fix/invoke view only #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
force-pushed
the
fix/invoke-view-only
branch
2 times, most recently
from
November 4, 2024 19:43
24b41b5
to
0eb337b
Compare
elizabethengelman
force-pushed
the
fix/invoke-view-only
branch
from
November 4, 2024 19:44
0eb337b
to
811d6fe
Compare
willemneal
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me to move the send check to after parsing the arguments!
elizabethengelman
force-pushed
the
fix/invoke-view-only
branch
from
November 12, 2024 22:23
f4783b6
to
01585f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This allows users to invoke a contract with a view-only transaction to use a default account instead of erroring if the account doesn't exist on the passed network.
Closes #1454
Why
Currently in the CLI, if you pass the
--help
flag for example, but pass an account that doesn't exist on the configured network, you would see an error. With this change, you will not see an error, just the help menu.Known limitations
n/a