fix: Add ContractAddress type to consolidate contract id parsing with aliases #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Oct 30, 2024
|
It seems that this is not needed since it is resolved in the function that fetches the wasm. However, given the work that @fnando is doing with the config it might be worth adding a similar |
|
Change seems to be super simple but looks like there are some test failures cause of error types |
willemneal
force-pushed
the
fix/contract_info
branch
from
e87deec to
90287f8
Compare
Ifropc
reviewed
Nov 1, 2024
|
Converted to draft because builds seem to be broken. |
willemneal
changed the title
…nto stellar-cli/fix/contract_info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New type is similar to Address (which later should be combined since contract addresses can be used with
contract invokecontract method args.