Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unit testing/add ARM support #1691

Merged
merged 34 commits into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
af05e8f
WIP: check make test
Ifropc Oct 29, 2024
82cd749
Update makefile
Ifropc Oct 29, 2024
1ae3d82
Cleanup
Ifropc Oct 29, 2024
b06cea2
Deprecation fix
Ifropc Oct 29, 2024
36d2417
Add build target
Ifropc Oct 30, 2024
d0f8dfb
Add libssl-dev
Ifropc Oct 30, 2024
4a5bdff
Print openssl dir
Ifropc Oct 30, 2024
bc9da35
cfg path
Ifropc Oct 30, 2024
bffcd8f
cfg path
Ifropc Oct 30, 2024
a9c3982
Add sysroot
Ifropc Oct 30, 2024
e81df41
libssl
Ifropc Oct 30, 2024
75e147f
ls
Ifropc Oct 30, 2024
c7d814d
fix apt
Ifropc Oct 30, 2024
b3c0d42
ln
Ifropc Oct 30, 2024
aafb54c
libssl
Ifropc Oct 30, 2024
7cdbbc7
arm
Ifropc Oct 30, 2024
ebffbe3
...
Ifropc Oct 30, 2024
b9fc79f
tmate
Ifropc Oct 30, 2024
0497af4
apt sources
Ifropc Oct 30, 2024
2bf08fb
Remove tmate
Ifropc Oct 30, 2024
c174080
libudev arm64
Ifropc Oct 30, 2024
78e4820
Change runner to arm
Ifropc Oct 30, 2024
d47d09e
Fix rust job
Ifropc Oct 30, 2024
5823ead
Update rust-cache
Ifropc Oct 30, 2024
049ce66
Uncomment other OSes
Ifropc Oct 30, 2024
937ec26
Merge remote-tracking branch 'origin/main' into arm-test
Ifropc Oct 30, 2024
2551936
Cleanup apt
Ifropc Oct 30, 2024
7ee0ffa
Merge branch 'main' into arm-test
Ifropc Oct 30, 2024
3a755c2
Update rust-cache
Ifropc Oct 30, 2024
b8eec8d
Unpin rust-cache version
Ifropc Oct 31, 2024
258e17b
Merge branch 'main' into arm-test
Ifropc Nov 5, 2024
0245d10
keep apt-get
leighmcculloch Nov 6, 2024
517fbaf
Merge branch 'main' into arm-test
leighmcculloch Nov 6, 2024
a03e491
Merge branch 'main' into arm-test
fnando Nov 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
sys:
- os: ubuntu-latest-16-cores
target: x86_64-unknown-linux-gnu
- os: ubuntu-latest-16-cores
- os: ubuntu-jammy-16-cores-arm64
target: aarch64-unknown-linux-gnu
- os: macos-latest
target: x86_64-apple-darwin
fnando marked this conversation as resolved.
Show resolved Hide resolved
Expand Down Expand Up @@ -79,14 +79,10 @@ jobs:
- if: runner.os == 'Linux'
run: sudo apt-get update && sudo apt-get -y install gcc-aarch64-linux-gnu g++-aarch64-linux-gnu libudev-dev
- run: cargo clippy --all-targets --target ${{ matrix.sys.target }}
- run: make build-test
# TODO: enable ARM linux
- if: startsWith(matrix.sys.target, 'x86_64') || runner.os == 'macOS'
# specify directories explicitly (otherwise it will fail with missing symbols)
run: |
for I in cmd/soroban-cli cmd/crates/* cmd/crates/soroban-test/tests/fixtures/test-wasms/hello_world ; do
cargo test --target ${{ matrix.sys.target }} --manifest-path $I/Cargo.toml
done
- run: make test
Ifropc marked this conversation as resolved.
Show resolved Hide resolved
env:
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER: aarch64-linux-gnu-gcc
CARGO_BUILD_TARGET: ${{ matrix.sys.target }}

publish-dry-run:
if: github.event_name == 'push' || startsWith(github.head_ref, 'release/')
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ generate-full-help-doc:
cargo run --bin doc-gen --features clap-markdown

test: build-test
cargo test
cargo test --workspace

e2e-test:
cargo test --features it --test it -- integration
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ use token::Client as TokenClient;
use token::StellarAssetClient as TokenAdminClient;

fn create_token_contract<'a>(e: &Env, admin: &Address) -> (TokenClient<'a>, TokenAdminClient<'a>) {
let contract_address = e.register_stellar_asset_contract(admin.clone());
let contract_address = e
.register_stellar_asset_contract_v2(admin.clone())
.address();
(
TokenClient::new(e, &contract_address),
TokenAdminClient::new(e, &contract_address),
Expand Down
Loading