Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-deny for license checks and dep duplicate avoidance #1685

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Oct 24, 2024

What

Add cargo-deny.

Why

To perform license checks and identify unnecessarily dependency duplication that increases build time and binary size.

The config was taken from the rs-soroban-sdk repo with minor changes made to fit.

We should have added this a while ago.

@leighmcculloch leighmcculloch marked this pull request as ready for review October 24, 2024 23:56
Ifropc
Ifropc previously approved these changes Oct 30, 2024
@Ifropc Ifropc dismissed their stale review October 30, 2024 23:02

CI fail cause of dependencies

@leighmcculloch leighmcculloch marked this pull request as draft October 31, 2024 05:07
@leighmcculloch leighmcculloch enabled auto-merge (squash) November 6, 2024 22:51
@leighmcculloch leighmcculloch merged commit 0b4c363 into main Nov 6, 2024
28 of 30 checks passed
@leighmcculloch leighmcculloch deleted the Add-cargo-deny-for-license-checks-and-dep-duplicate-avoidance branch November 6, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants