-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cargo-deny for license checks and dep duplicate avoidance #1685
Merged
leighmcculloch
merged 19 commits into
main
from
Add-cargo-deny-for-license-checks-and-dep-duplicate-avoidance
Nov 6, 2024
Merged
Add cargo-deny for license checks and dep duplicate avoidance #1685
leighmcculloch
merged 19 commits into
main
from
Add-cargo-deny-for-license-checks-and-dep-duplicate-avoidance
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plicate-avoidance
Ifropc
reviewed
Oct 30, 2024
Ifropc
previously approved these changes
Oct 30, 2024
…plicate-avoidance
fnando
approved these changes
Nov 6, 2024
leighmcculloch
deleted the
Add-cargo-deny-for-license-checks-and-dep-duplicate-avoidance
branch
November 6, 2024 23:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add cargo-deny.
Why
To perform license checks and identify unnecessarily dependency duplication that increases build time and binary size.
The config was taken from the
rs-soroban-sdk
repo with minor changes made to fit.We should have added this a while ago.