Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tx op add #1663

Merged
merged 26 commits into from
Dec 4, 2024
Merged

feat: add tx op add #1663

merged 26 commits into from
Dec 4, 2024

Conversation

willemneal
Copy link
Member

@willemneal willemneal commented Oct 8, 2024

This allows chaining tx op add commands to build up a transaction with multiple operations.

This allows chaining `tx add-op` commands to build up a transaction with multiple operations.
@willemneal willemneal self-assigned this Oct 8, 2024
@willemneal
Copy link
Member Author

Still need more tests.

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor things, otherwise lgtm 👏🏻

FULL_HELP_DOCS.md Outdated Show resolved Hide resolved
cmd/soroban-cli/src/commands/tx/xdr.rs Outdated Show resolved Hide resolved
cmd/soroban-cli/src/commands/tx/add_op/args.rs Outdated Show resolved Hide resolved
@willemneal willemneal changed the title feat: add tx add-op feat: add tx op add Nov 5, 2024
@leighmcculloch leighmcculloch self-requested a review November 6, 2024 13:19
@sagpatil
Copy link

#1566 Linked

@sagpatil sagpatil linked an issue Nov 26, 2024 that may be closed by this pull request
@leighmcculloch leighmcculloch enabled auto-merge (squash) December 4, 2024 15:13
@leighmcculloch leighmcculloch merged commit a03b1d7 into main Dec 4, 2024
30 checks passed
@leighmcculloch leighmcculloch deleted the feat/tx_add_op branch December 4, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Design for creating and combining multiple operations via CLI
4 participants