Feat: add stellar ledger as signer #1627
Conversation
willemneal
changed the title
|
@leighmcculloch Moved here |
willemneal
force-pushed
the
feat/add_stellar_ledger
branch
from
2b7c74a to
0aaf7c5
Compare
willemneal
requested review from
elizabethengelman,
fnando and
leighmcculloch
| @@ -0,0 +1,7 @@ | |||
| pub mod http_transport; | |||
There was a problem hiding this comment.
should http_transport be under the emulator-tests feature flag too?
There was a problem hiding this comment.
I meant to add a http-transport feature. above it because some unit tests still needed it.
| } | ||
|
|
||
| #[derive(Debug, Clone, Eq, PartialEq)] | ||
| pub enum DeviceModel { |
There was a problem hiding this comment.
👏 love this refactor
| @@ -394,23 +394,61 @@ impl Cmd { | |||
| .ok_or(Error::ArchiveUrlNotConfigured) | |||
| } | |||
|
|
|||
| fn resolve_address( | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
do we need to include resolve_address here if it's not being used?
|
|
||
| // Resolve an account address to an account id. The address can be a | ||
| // G-address or a key name (as in `stellar keys address NAME`). | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
same here - do we need to keep this in here if it's dead code??
|
|
||
| use crate::integration::util::{deploy_contract, DeployKind, HELLO_WORLD}; | ||
|
|
||
| // #[test_case("nanos"; "when the device is NanoS")] |
There was a problem hiding this comment.
I wonder if we can uncomment these other device model test cases
There was a problem hiding this comment.
I was running into issues around the server locally. Since all the accounts share the same seed phrase it was acting as one account. I also tried updating the testcase to add an hd-path, but it was causes issues. So I just wanted one to work on CI and then was going to return to it.
| } | ||
| } | ||
|
|
||
| impl std::str::FromStr for KeyName { |
There was a problem hiding this comment.
I think that it makes sense not to allow for key names to be "ledger*", but I'm wondering how we can add a ledger identity via the cli - is this possible? If not, i think we want to revise the doc comment in cmd/soroban-cli/src/commands/keys/mod.rs for Add.
What
replaces #1415
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]