Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sandbox command to contain deploy, invoke, read #144

Closed
wants to merge 1 commit into from

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Sep 20, 2022

What

Add sandbox command to contain the sandbox versions of deploy, invoke, read.

Why

I took a quick look at how a remote deploy command would be added (#41) and it soon became overwhelming thinking about how to have such a command coexist with the code in the sandbox deploy command.

At some point someone had expressed interest in grouping sandbox command under a sandbox super command so as to clearly separate them from commands that invoke remote services. I think it might have been @paulbellamy who had dropped this idea in a doc a long time ago.

We never did it, but I think it will make it easier to implement the following tasks if we have the sandbox variations under sandbox and put the remote variations of the commands under another subcommand such as remote:

This change makes no functional changes and is purely moving code into a directory (so it is in a Rust module under sandbox), and inserting the sandbox command in between them.

Close #165

@leighmcculloch
Copy link
Member Author

leighmcculloch commented Sep 20, 2022

I didn't include serve in this change because while I assume it'd probably live under sandbox, I didn't want to move the file right now since other people might be working on it.

@leighmcculloch leighmcculloch marked this pull request as draft September 29, 2022 20:52
@leighmcculloch leighmcculloch deleted the movesandboxcommandundersandbox branch October 1, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: Separate sandbox command into a separate top-level command
1 participant