Code

Fix/network container improvements#1423

Code

Merged

elizabethengelman merged 38 commits intostellar:mainstellar/stellar-cli:mainfrom AhaLabs:fix/network-container-improvementsAhaLabs/stellar-cli:fix/network-container-improvementsCopy head branch name to clipboardJul 22, 2024

+295-231

Commits

Commits on Jul 15, 2024

• Return a better error message when stopping container that doesn't exist

  elizabethengelman

  committed
  d26eb22

  Copy full SHA for d26eb22

• Fix doc strings for network container commands

  elizabethengelman

  committed
  321a48f

  Copy full SHA for 321a48f

• Pull shared container args to shared.rs

  elizabethengelman

  committed
  ae4ea7f

  Copy full SHA for ae4ea7f

• Allow for overwriting the default container name with -c

  elizabethengelman

  committed
  5c67caf

  Copy full SHA for 5c67caf

• Check in generated doc updates

  elizabethengelman

  committed
  70b6c39

  Copy full SHA for 70b6c39

• Refactor printlns

  elizabethengelman

  committed
  89bceec

  Copy full SHA for 89bceec

• Clippy & cleanup errors

  elizabethengelman

  committed
  d800be5

  Copy full SHA for d800be5

• Rename ContainerArgs -> Args

  elizabethengelman

  committed
  196c5e5

  Copy full SHA for 196c5e5

• Update cmd/soroban-cli/src/commands/network/container/start.rs

  Show description for 07ccbda
  

  elizabethengelman

  and

  willemneal

  authored
  07ccbda

  Copy full SHA for 07ccbda

• Use expect instead of unwrap in get_container_name

  elizabethengelman

  committed
  523adb2

  Copy full SHA for 523adb2

• Add get_additional_flags fn on Args to reduce duplication

  elizabethengelman

  committed
  c81f788

  Copy full SHA for c81f788

• Add get_container_name_arg fn on Args to reduce duplication

  elizabethengelman

  committed
  ce13f84

  Copy full SHA for ce13f84

• Apply suggestions from code review

  Show description for 2a16a42
  

  elizabethengelman

  and

  willemneal

  committed
  2a16a42

  Copy full SHA for 2a16a42

• Add a comment explaining get_container_name_arg

  elizabethengelman

  committed
  8704b32

  Copy full SHA for 8704b32

Commits on Jul 16, 2024

• Clean up doc comments

  elizabethengelman

  committed
  479fb13

  Copy full SHA for 479fb13

• Simplify stop and logs commmands

  Show description for 305c281
  elizabethengelman

  committed
  305c281

  Copy full SHA for 305c281

• Update the docs

  elizabethengelman

  committed
  2f17a58

  Copy full SHA for 2f17a58

• Revert "Simplify stop and logs commmands"

  Show description for 299e036
  elizabethengelman

  committed
  299e036

  Copy full SHA for 299e036

• Rename container_name arg to name

  elizabethengelman

  committed
  c2670e2

  Copy full SHA for c2670e2

• Update help docs

  elizabethengelman

  committed
  a9fa5b0

  Copy full SHA for a9fa5b0

• Clippy

  elizabethengelman

  committed
  aac2440

  Copy full SHA for aac2440

• Move connect_to_docker to Arg impl

  elizabethengelman

  committed
  3ed3586

  Copy full SHA for 3ed3586

• Refactor start command: move helper fns to Cmd impl

  elizabethengelman

  committed
  fcb28dc

  Copy full SHA for fcb28dc

• Merge branch 'main' into fix/network-container-improvements

  elizabethengelman

  authored
  33b51bd

  Copy full SHA for 33b51bd

• Default container name to network name

  Show description for e997527
  elizabethengelman

  committed
  e997527

  Copy full SHA for e997527

• Update stop and logs commands to accept the container name

  Show description for aadfc63
  elizabethengelman

  committed
  aadfc63

  Copy full SHA for aadfc63

• Update docs

  elizabethengelman

  committed
  e96b8e1

  Copy full SHA for e96b8e1

Commits on Jul 17, 2024

• Merge branch 'main' into fix/network-container-improvements

  elizabethengelman

  authored
  a18ac18

  Copy full SHA for a18ac18

• Merge branch 'main' into fix/network-container-improvements

  elizabethengelman

  authored
  f79b59d

  Copy full SHA for f79b59d

Commits on Jul 18, 2024

• Create a Name type to handle internal vs external name conventions

  elizabethengelman

  committed
  0c95562

  Copy full SHA for 0c95562

• Prefix container names with 'stellar-'

  elizabethengelman

  committed
  235f521

  Copy full SHA for 235f521

• Add tests for Name struct

  elizabethengelman

  committed
  03d29ac

  Copy full SHA for 03d29ac

• Refactor Name fns

  elizabethengelman

  committed
  392e1f6

  Copy full SHA for 392e1f6

• Merge branch 'main' into fix/network-container-improvements

  elizabethengelman

  authored
  42a9bfc

  Copy full SHA for 42a9bfc

• Merge branch 'main' into fix/network-container-improvements

  elizabethengelman

  authored
  6fbb3f3

  Copy full SHA for 6fbb3f3

• Update Name::new to just take in one arg

  Show description for ec3d39f
  

  elizabethengelman

  and

  willemneal

  committed
  ec3d39f

  Copy full SHA for ec3d39f

• Refactor Name

  elizabethengelman

  committed
  996dea4

  Copy full SHA for 996dea4

• Merge branch 'main' into fix/network-container-improvements

  elizabethengelman

  authored
  c7c465c

  Copy full SHA for c7c465c