Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cli readme #1225

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Update cli readme #1225

merged 4 commits into from
Mar 5, 2024

Conversation

janewang
Copy link
Contributor

@janewang janewang commented Feb 28, 2024 •
edited
Loading

What

Update readme and contributing.md

Why

Provide guidance on the cli and how to contribute

Known limitations

@janewang janewang requested a review from willemneal February 28, 2024 15:49
willemneal
willemneal reviewed Feb 28, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
willemneal
willemneal approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one nit.

@willemneal
Copy link
Member

It looks like a new example was added. So you need to run cargo md-gen to generate the markdown docs.

@willemneal willemneal enabled auto-merge (squash) March 5, 2024 17:56
@willemneal willemneal merged commit ba631ff into stellar:main Mar 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willemneal willemneal willemneal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janewang @willemneal