Add note about eviction

stellar · Sep 5, 2023 · 35abf5b · 35abf5b
1 parent 6e1f270
commit 35abf5b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/cmd/soroban-rpc/internal/ingest/service.go b/cmd/soroban-rpc/internal/ingest/service.go
@@ -292,6 +292,10 @@ func (s *Service) evictLedgerEntries(tx db.WriteTx, ledgerCloseMeta xdr.LedgerCl
 	keysToEvict := make([]xdr.LedgerKey, len(ledgerCloseMeta.V2.EvictedTemporaryLedgerKeys)+len(ledgerCloseMeta.V2.EvictedPersistentLedgerEntries))
 	l := copy(keysToEvict, ledgerCloseMeta.V2.EvictedTemporaryLedgerKeys)
 	for i, entry := range ledgerCloseMeta.V2.EvictedPersistentLedgerEntries {
+		// TODO: we probably shouldn't be deleting evicted persistent ledger entries cold turkey.
+		//       Otherwise preflighting will fail for restoreFootprint.
+		//       For restoreFootPrint we need to confirm that the entry existed and its size (for the resource estimation).
+		//       so maybe we should store that.
 		key, err := entry.LedgerKey()
 		if err != nil {
 			return err