Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rust version to 1.79 #384

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Bump Rust version to 1.79 #384

merged 3 commits into from
Aug 15, 2024

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Aug 14, 2024

What

Bump Rust version to 1.79

Why

We're doing this bump for env and we need to fix the XDR library warnings anyways.

Known limitations

N/A

We're doing this bump for env and we need to fix the XDR library warnings anyways.
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update the minimum supported rust version, but it's not clear we need to, because the PR description isn't clear as to why the version is being updated. No changes in the PR are using new rust features that require a newer version.

Cargo.toml Outdated Show resolved Hide resolved
@dmkozh dmkozh added this pull request to the merge queue Aug 15, 2024
Merged via the queue into stellar:main with commit 84cc773 Aug 15, 2024
11 checks passed
@dmkozh dmkozh deleted the rust_bump branch August 15, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants