Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getTransactions endpoint support #3

Merged
merged 17 commits into from
Jul 23, 2024

Conversation

BlaineHeffron
Copy link
Contributor

What

Adding support for GetTransactions endpoint

Why

achieve feature parity with the RPC code

Known limitations

N/A

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one question and one nit

@BlaineHeffron
Copy link
Contributor Author

Should be ready now, thanks.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@BlaineHeffron BlaineHeffron force-pushed the feat/GetTransactions branch from 278f1cc to 0e42859 Compare July 16, 2024 17:12
src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about the seemingly unused Error case.

@willemneal willemneal merged commit 5720f4b into stellar:main Jul 23, 2024
6 checks passed
@willemneal willemneal deleted the feat/GetTransactions branch July 23, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants