-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add getTransactions endpoint support #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
reviewed
Jul 15, 2024
willemneal
reviewed
Jul 15, 2024
willemneal
requested changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one question and one nit
Should be ready now, thanks. |
willemneal
reviewed
Jul 16, 2024
willemneal
reviewed
Jul 16, 2024
BlaineHeffron
force-pushed
the
feat/GetTransactions
branch
from
July 16, 2024 17:12
278f1cc
to
0e42859
Compare
BlaineHeffron
force-pushed
the
feat/GetTransactions
branch
from
July 17, 2024 22:37
0e42859
to
632985b
Compare
willemneal
reviewed
Jul 23, 2024
willemneal
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question about the seemingly unused Error case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding support for GetTransactions endpoint
Why
achieve feature parity with the RPC code
Known limitations
N/A