Revive read-tickets WIP #930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
read-tickets-redux
branch
2 times, most recently
from
f05e436
to
e43de82
Compare
| @@ -18,11 +20,74 @@ use super::{ | |||
| U64Object, Val, VecObject, | |||
| }; | |||
|
|
|||
| /// A ticket is a number that represents permission to read a set of host | |||
There was a problem hiding this comment.
Maybe I am missing something... but because objects have to be passed in as argument in order to be visible, this seems maybe over complicated? I think the only thing to keep track of is how deep in the stack something was shared.
There was a problem hiding this comment.
No, it's unfortunately much more complicated than that. As a minimal example speaking to your question: if A calls B(x), then x should be readable by B, sure; but if B returns and A then calls C(y), x should not be readable by C, even though C is "at the same call depth" as B was.
graydon
force-pushed
the
read-tickets-redux
branch
from
e43de82
to
85d5453
Compare
graydon
force-pushed
the
read-tickets-redux
branch
from
85d5453
to
664b660
Compare
This was referenced Jul 11, 2023
|
closing in favor of #947 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over from #132 which had bitrotted. Still WIP.