Enforce object handle integrity when inserting into containers, fix #569 #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
approved these changes
Jul 5, 2023
anupsdf
reviewed
Jul 5, 2023
| @@ -1974,6 +1992,8 @@ impl VmCallerEnv for Host { | |||
| t: StorageType, | |||
| f: Val, | |||
There was a problem hiding this comment.
Should we check value integrity for the input flag f as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't so much a "safety" issue as a confusion-of-users issue. We want to detect any malformed object handles (bad index, bad tags) as early as possible, so users don't have to diagnose late errors when a lookup finally traps.
Anyway, this makes it impossible to insert a malformed one into a container, and since containers are how you form argument lists to making calls, it implicitly confines malformed object handles to a single contract instance.