Turn dynamic borrow panics into HostErrors #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
bug-817-dynaimc-borrows-can-panic
branch
from
39a75b1
to
0dc99b8
Compare
dmkozh
approved these changes
Jul 4, 2023
graydon
added a commit
that referenced
this pull request
Jul 4, 2023
graydon
added a commit
that referenced
this pull request
Jul 5, 2023
* Mop up a couple missed cases from PR #925 * Cap vector and map sizes to u32::max * Cast usize to u64 before multiplying, for platform-consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #817
I'm still not 100% sure we want this -- a dynamic borrow error usually means there's something structurally wrong with the control pattern calling the function, and this might basically make it "recoverable" in some partial sense where it might be cleaner to panic out to the outermost panic handler -- but in either case if someone triggers one we'll be stuck preserving it for backwards compatibility for all time, and this might be a little easier to preserve?
Anyway, assuming we do, this does it.