Skip to content

Commit

Permalink
Add fully-qualified Operation type to XDR type definitions. (#591)
Browse files Browse the repository at this point in the history
* Add fully-qualified type (Operation is wrong)
* Add changelog & version bump
  • Loading branch information
Shaptic authored Apr 21, 2023
1 parent c29784d commit c7bcd02
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 16 deletions.
10 changes: 9 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,15 @@

## Unreleased

## [v9.0.0-beta.0](https://github.com/stellar/js-stellar-base/compare/v8.2.2..v9.0.0)

## [v9.0.0-beta.1](https://github.com/stellar/js-stellar-base/compare/v9.0.0-beta.0..v9.0.0-beta.1)

### Fix

- Correct XDR type definition for raw `xdr.Operation`s ([#591](https://github.com/stellar/js-stellar-base/pull/591)).


## [v9.0.0-beta.0](https://github.com/stellar/js-stellar-base/compare/v8.2.2..v9.0.0-beta.0)

This version is marked by a major version bump because of the significant upgrades to underlying dependencies. While there should be no noticeable API changes from a downstream perspective, there may be breaking changes in the way that this library is bundled.

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "stellar-base",
"version": "9.0.0-beta.0",
"version": "9.0.0-beta.1",
"description": "Low-level support library for the Stellar network.",
"main": "./lib/index.js",
"types": "./types/index.d.ts",
Expand Down
14 changes: 7 additions & 7 deletions types/curr.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Automatically generated on 2022-08-12T12:40:00+01:00
// Automatically generated on 2023-04-20T14:53:00-08:00
import { Operation } from './index';

export {};
Expand All @@ -20,17 +20,17 @@ declare namespace xdrHidden {

toXDR(format: "hex" | "base64"): string;

static read(io: Buffer): Operation;
static read(io: Buffer): xdr.Operation;

static write(value: Operation, io: Buffer): void;
static write(value: xdr.Operation, io: Buffer): void;

static isValid(value: Operation): boolean;
static isValid(value: xdr.Operation): boolean;

static toXDR(value: Operation): Buffer;
static toXDR(value: xdr.Operation): Buffer;

static fromXDR(input: Buffer, format?: "raw"): Operation;
static fromXDR(input: Buffer, format?: "raw"): xdr.Operation;

static fromXDR(input: string, format: "hex" | "base64"): Operation;
static fromXDR(input: string, format: "hex" | "base64"): xdr.Operation;

static validateXDR(input: Buffer, format?: "raw"): boolean;

Expand Down
14 changes: 7 additions & 7 deletions types/next.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Automatically generated on 2022-08-12T12:40:00+01:00
// Automatically generated on 2023-04-20T14:53:00-08:00
import { Operation } from './index';

export {};
Expand All @@ -20,17 +20,17 @@ declare namespace xdrHidden {

toXDR(format: "hex" | "base64"): string;

static read(io: Buffer): Operation;
static read(io: Buffer): xdr.Operation;

static write(value: Operation, io: Buffer): void;
static write(value: xdr.Operation, io: Buffer): void;

static isValid(value: Operation): boolean;
static isValid(value: xdr.Operation): boolean;

static toXDR(value: Operation): Buffer;
static toXDR(value: xdr.Operation): Buffer;

static fromXDR(input: Buffer, format?: "raw"): Operation;
static fromXDR(input: Buffer, format?: "raw"): xdr.Operation;

static fromXDR(input: string, format: "hex" | "base64"): Operation;
static fromXDR(input: string, format: "hex" | "base64"): xdr.Operation;

static validateXDR(input: Buffer, format?: "raw"): boolean;

Expand Down

0 comments on commit c7bcd02

Please sign in to comment.