Skip to content

Commit

Permalink
[CD/CI] Fix gh pages deploy (#461)
Browse files Browse the repository at this point in the history
### What
Fix gh pages [deploy](https://github.com/stellar/js-stellar-base/runs/3436212203?check_suite_focus=true):
1. The jsdoc command needs to be run by yarn with `yarn jsdoc`.
2. There was a wrong jsdoc return type in `asset.js`.
  • Loading branch information
marcelosalloum authored Aug 26, 2021
1 parent df99d24 commit 3fa1b1e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/gh_pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
run: gulp

- name: Generate JSDoc
run: jsdoc -c .jsdoc.json --verbose
run: yarn jsdoc -c .jsdoc.json --verbose

- name: Deploy to GH Pages
uses: JamesIves/github-pages-deploy-action@12a916dfb718ab8fc2ec3ad7cb731a89d7d23332
Expand Down
2 changes: 1 addition & 1 deletion src/asset.js
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ export class Asset {
* @static
* @param {Asset} assetA - The first asset in the lexicographic order.
* @param {Asset} assetB - The second asset in the lexicographic order.
* @return {-1 | 0 | 1} `-1` if assetA < assetB, `0` if assetA == assetB, `1` if assetA > assetB.
* @return {number} `-1` if assetA < assetB, `0` if assetA == assetB, `1` if assetA > assetB.
* @memberof Asset
*/
static compare(assetA, assetB) {
Expand Down

0 comments on commit 3fa1b1e

Please sign in to comment.