[ANCHOR-784] Remove 0 amounts from SEP-6 transaction responses #1469
Conversation
| expectedResponse.amountExpected = Amount(null, FIAT_USD) | ||
| expectedResponse.amountIn = Amount("1", FIAT_USD) |
There was a problem hiding this comment.
This seems wrong, we default to the request asset code when the assets are not found in the transaction. https://github.com/stellar/java-stellar-anchor-sdk/blob/0834773d350c1eef61ffcf2cb71fe9eb17f7232f/core/src/main/java/org/stellar/anchor/util/TransactionHelper.java#L218
There was a problem hiding this comment.
I think it is possible that the transaction asset had not been written by RPC and we need to respond with the asset id.
Same logic exists at: https://github.com/stellar/java-stellar-anchor-sdk/blob/0834773d350c1eef61ffcf2cb71fe9eb17f7232f/core/src/main/java/org/stellar/anchor/util/TransactionHelper.java#L230
philipliu
changed the title
| expectedResponse.amountExpected = Amount(null, FIAT_USD) | ||
| expectedResponse.amountIn = Amount("1", FIAT_USD) |
There was a problem hiding this comment.
I think it is possible that the transaction asset had not been written by RPC and we need to respond with the asset id.
Same logic exists at: https://github.com/stellar/java-stellar-anchor-sdk/blob/0834773d350c1eef61ffcf2cb71fe9eb17f7232f/core/src/main/java/org/stellar/anchor/util/TransactionHelper.java#L230
Description
This removes the 0
amount_outand 0amount_feeplaceholder values from the SEP-6 exchange transaction responses.Context
This was set as a placeholder because the request funds RPCs expected these fields always to be set.
Testing
./gradlew testDocumentation
N/A
Known limitations
N/A