Conform AspectIdentifier to AspectToken #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I'm not mistaken AspectIdentifier is what being returned by `aspect_hookSelector…` method If so it's advertised that it would conform to `AspectToken` protocol It does it in informal way (by just implementing required methods) What it means is that if we check the object returned by `aspect_hookSelector…` method at runtime for the protocol conformance it will actually fail which can impact user logic relying on that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm not mistaken AspectIdentifier is what being returned by
aspect_hookSelector…methodIf so it's advertised that it would conform to
AspectTokenprotocolIt does it in informal way (by just implementing required methods)
What it means is that if we check the object returned by
aspect_hookSelector…method at runtime for the protocol conformance it will actually fail which can impact user logic relying on that