Add siblings-only finders (excluding the targeted node) #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds support for siblings-only finders and scope, eg.
#siblings_only
mainly.Excluding the targeted node from the list of its siblings is as simple as
node.siblings.reject { |s| s == node }
, but it might make more sense to handle that within ancestry itself so as to leverage a cleaner, more efficient SQL query, and to provide a full-fledged API (eg.Model.siblings_only_of(node)
,Model#siblings_only_ids
).