Make WriteCharacteristic fail if types mismatch #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this pull request. This looks good to me, but I would like to also get our senior engineer to have a look as well. @nbrooke when you have time can you also review this PR? Thanks. |
|
Any updates on this? @sakuraehikaru @nbrooke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263:
Summary of Problem:
There's no way to know if a characteristic has the specified CBCharacteristicWriteType when calling write because if it doesn't, success is returned instead of fail.
Proposed Solution:
In
WriteCharacteristicwe check that theCBCharacteristichas the passed type as a property, if it doesn't we fail the write.Testing Completed and Required:
Calling
writewith a mismatchedCBCharacteristicWriteTypeexecutes thefailcallback.