Skip to content

Commit

Permalink
feat: make probes configurable via helm-chart
Browse files Browse the repository at this point in the history
  • Loading branch information
@ReuDa
ReuDa committed Nov 21, 2023
1 parent d83ee77 commit 2aca72b
Show file tree
Hide file tree
Showing 4 changed files with 127 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/steadybit-extension-datadog/Chart.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: steadybit-extension-datadog
description: Steadybit Kubernetes extension Helm chart for Datadog.
version: 1.4.23
version: 1.4.24
appVersion: latest
home: https://www.steadybit.com/
icon: https://steadybit-website-assets.s3.amazonaws.com/logo-symbol-transparent.png
Expand Down
10 changes: 10 additions & 0 deletions charts/steadybit-extension-datadog/templates/deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,20 @@ spec:
volumeMounts:
{{- include "extensionlib.deployment.volumeMounts" (list .) | nindent 12 }}
livenessProbe:
initialDelaySeconds: {{ .Values.probes.liveness.initialDelaySeconds }}
periodSeconds: {{ .Values.probes.liveness.periodSeconds }}
timeoutSeconds: {{ .Values.probes.liveness.timeoutSeconds }}
successThreshold: {{ .Values.probes.liveness.successThreshold }}
failureThreshold: {{ .Values.probes.liveness.failureThreshold }}
httpGet:
path: /health/liveness
port: 8091
readinessProbe:
initialDelaySeconds: {{ .Values.probes.readiness.initialDelaySeconds }}
periodSeconds: {{ .Values.probes.readiness.periodSeconds }}
timeoutSeconds: {{ .Values.probes.readiness.timeoutSeconds }}
successThreshold: {{ .Values.probes.readiness.successThreshold }}
failureThreshold: {{ .Values.probes.readiness.failureThreshold }}
httpGet:
path: /health/readiness
port: 8091
Expand Down
100 changes: 100 additions & 0 deletions charts/steadybit-extension-datadog/tests/__snapshot__/deployment_test.yaml.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,26 @@ manifest should match snapshot using podAnnotations and Labels:
image: ghcr.io/steadybit/extension-datadog:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
ports:
- containerPort: 8090
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -141,16 +151,26 @@ manifest should match snapshot with TLS:
image: ghcr.io/steadybit/extension-datadog:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
ports:
- containerPort: 8090
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -238,16 +258,26 @@ manifest should match snapshot with extra env vars:
image: ghcr.io/steadybit/extension-datadog:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
ports:
- containerPort: 8090
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -323,16 +353,26 @@ manifest should match snapshot with extra labels:
image: ghcr.io/steadybit/extension-datadog:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
ports:
- containerPort: 8090
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -410,16 +450,26 @@ manifest should match snapshot with mock server:
image: ghcr.io/steadybit/extension-datadog:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
ports:
- containerPort: 8090
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -499,16 +549,26 @@ manifest should match snapshot with mutual TLS:
image: ghcr.io/steadybit/extension-datadog:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
ports:
- containerPort: 8090
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -602,16 +662,26 @@ manifest should match snapshot with mutual TLS using containerPaths:
image: ghcr.io/steadybit/extension-datadog:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
ports:
- containerPort: 8090
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -685,16 +755,26 @@ manifest should match snapshot with podSecurityContext:
image: ghcr.io/steadybit/extension-datadog:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
ports:
- containerPort: 8090
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -770,16 +850,26 @@ manifest should match snapshot with priority class:
image: ghcr.io/steadybit/extension-datadog:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
ports:
- containerPort: 8090
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down Expand Up @@ -854,16 +944,26 @@ manifest should match snapshot without TLS:
image: ghcr.io/steadybit/extension-datadog:latest
imagePullPolicy: Always
livenessProbe:
failureThreshold: 5
httpGet:
path: /health/liveness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 5
name: extension
ports:
- containerPort: 8090
readinessProbe:
failureThreshold: 3
httpGet:
path: /health/readiness
port: 8091
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources:
limits:
cpu: 200m
Expand Down
16 changes: 16 additions & 0 deletions charts/steadybit-extension-datadog/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,22 @@ logging:
# logging.format -- The format of the log entries. One of text, json
format: text

probes:
# probes.readiness.* -- Configuration of the Kubernetes readiness probe
readiness:
initialDelaySeconds: 10
periodSeconds: 10
timeoutSeconds: 1
failureThreshold: 3
successThreshold: 1
# probes.liveness.* -- Configuration of the Kubernetes liveness probe
liveness:
initialDelaySeconds: 10
periodSeconds: 10
timeoutSeconds: 5
failureThreshold: 5
successThreshold: 1

resources:
requests:
# resources.requests.memory -- The minimal amount of memory needed
Expand Down

0 comments on commit 2aca72b

Please sign in to comment.