Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues #225, #226 and #228. #482

Closed
wants to merge 3 commits into from
Closed

Fix issues #225, #226 and #228. #482

wants to merge 3 commits into from

Conversation

mhmdaminraeisi
Copy link

@mhmdaminraeisi mhmdaminraeisi commented Feb 4, 2022 •
edited by kgryte
Loading

Resolve issues #226, #225 and #228 .

Description

What is the purpose of this pull request?

This pull request:

  • adds support for computing the secant
  • adds support for computing the cosecant
  • adds support for computing the hyperbolic secant

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@mhmdaminraeisi mhmdaminraeisi changed the title Fix issue #226. Fix issues #225 and #226. Feb 4, 2022
@mhmdaminraeisi mhmdaminraeisi changed the title Fix issues #225 and #226. Fix issues #225, #226 and #228. Feb 4, 2022
@kgryte
Copy link
Member

kgryte commented Feb 15, 2022

@mhmdaminraeisi You mind checking the box above to indicate that you've read the contributing guidelines? In particular, checking this box means agreeing to the licensing terms.

kgryte
kgryte requested changes Feb 17, 2022
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until the author agrees to the contribution guidelines, this PR cannot move forward.

@kgryte kgryte added Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. Math Issue or pull request specific to math functionality. labels Feb 17, 2022
@kgryte
Copy link
Member

kgryte commented Feb 28, 2022

@mhmdaminraeisi Checking in to see if you'd be willing to update your OP as discussed above.

1 similar comment
@kgryte
Copy link
Member

kgryte commented Jun 1, 2022

@mhmdaminraeisi Checking in to see if you'd be willing to update your OP as discussed above.

@kgryte
Copy link
Member

kgryte commented Sep 21, 2023

Closing this PR due to inactivity.

@kgryte kgryte closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte requested changes

Assignees
No one assigned
Labels
Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
2 participants
@mhmdaminraeisi @kgryte