Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/gcdf #2997

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

feat: add math/base/special/gcdf #2997

wants to merge 17 commits into from
+2,467 −0

Conversation

aayush0325
Copy link
Contributor

@aayush0325 aayush0325 commented Oct 9, 2024 •
edited by kgryte
Loading

Resolves part of #649 .

Description

What is the purpose of this pull request?

This pull request:

  • adds math/base/special/gcdf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • Open to reviews !!

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Oct 9, 2024
@aayush0325
Copy link
Contributor Author

@Planeshifter Ready for initial review!

@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Oct 10, 2024
gunjjoshi
gunjjoshi reviewed Oct 10, 2024
View reviewed changes
lib/node_modules/@stdlib/math/base/special/gcdf/src/main.c
*/

#include "stdlib/math/base/special/gcdf.h"
#include "stdlib/math/base/special/fmod.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use the single-precision implementation of fmod here, i.e., fmodf, which we do not have currently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies. I did look for it in #649 but I did not see it there, so I went ahead and used fmod

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this. #649 is updated now, fmodf has been added.

@gunjjoshi
Copy link
Member

Thanks @aayush0325, we'll require fmodf to proceed with this. Once we have that, we can come back here.

@aayush0325
Copy link
Contributor Author

Thanks for your time @gunjjoshi , I have applied the changes from the code review, please ping this PR when fmodf gets added.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunjjoshi gunjjoshi gunjjoshi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aayush0325 @gunjjoshi @Planeshifter @kgryte @stdlib-bot