Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C ndarray API and refactor blas/ext/base/zfill #2962

Merged
merged 11 commits into from
Oct 1, 2024

Conversation

headlessNode
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds add C ndarray API and refactor blas/ext/base/zfill

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@headlessNode headlessNode marked this pull request as draft September 28, 2024 18:46
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 28, 2024
@headlessNode headlessNode marked this pull request as ready for review September 30, 2024 06:58
@headlessNode headlessNode marked this pull request as draft September 30, 2024 07:06
@headlessNode headlessNode marked this pull request as ready for review September 30, 2024 08:25
@headlessNode headlessNode marked this pull request as draft September 30, 2024 08:34
@headlessNode
Copy link
Contributor Author

headlessNode commented Sep 30, 2024

@kgryte I'll go ahead and apply the test changes in this PR.

@headlessNode headlessNode marked this pull request as ready for review September 30, 2024 09:00
@kgryte
Copy link
Member

kgryte commented Oct 1, 2024

@headlessNode In the future, we will want to split "mixed" changes across multiple PRs. E.g., adding a new feature with making fixes to tests and documentation. Because of how we perform automatic changelog generation, we rely on commits which do not conflate multiple changes. E.g., if we add a new feature, that triggers a semver minor change in a package, but a doc or test change should only trigger a semver patch. However, if a commit has both new features and patch changes, packages may be inadvertently bumped higher than necessary.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Oct 1, 2024
@headlessNode
Copy link
Contributor Author

@kgryte understood.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just a final question.

@kgryte kgryte added the C Issue involves or relates to C. label Oct 1, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@headlessNode
Copy link
Contributor Author

@kgryte Heads up. I am getting a failing test due to the change M=16, I am finding the reason/solution.

@kgryte kgryte merged commit f446206 into stdlib-js:develop Oct 1, 2024
10 checks passed
@headlessNode headlessNode deleted the zfill-refactor branch October 2, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants