Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iter/cusome-by #2826

Merged
merged 8 commits into from
Oct 9, 2024
Merged

Conversation

gururaj1512
Copy link
Contributor

@gururaj1512 gururaj1512 commented Aug 23, 2024

Resolves #2338.

Description

What is the purpose of this pull request?
This pull request resolves issue #2338

This pull request:

  • This pull request adds feature @stdlib/iter/cusome-by

Related Issues

Does this pull request have any related issues?
I am new contributor to stdlib might need some guidance if something is wrong

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@Planeshifter Planeshifter changed the title feat: add iter/cusome-by feat: add iter/cusome-by Aug 24, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Aug 24, 2024
@Planeshifter Planeshifter self-requested a review September 7, 2024 00:22
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. labels Oct 4, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Will merge shortly after fixing a few things...

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Oct 9, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `iter/cusome-by`

PR-URL: https://github.com/stdlib-js/stdlib/pull/2826
Closes: https://github.com/stdlib-js/stdlib/issues/2338

Co-authored-by: Gururaj Gurram <[email protected]>
Co-authored-by: Gururaj Gurram <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gururaj Gurram <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit fd271be into stdlib-js:develop Oct 9, 2024
18 checks passed
@gururaj1512 gururaj1512 deleted the add-cusome-by branch October 9, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/iter/cusome-by
4 participants