Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lapack/base/dlae2 #2824

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat: add lapack/base/dlae2 #2824

wants to merge 6 commits into from

Conversation

Pranavchiku
Copy link
Member

Towards #2464.

Description

What is the purpose of this pull request?

This pull request adds JS implementation for lapack/base/dlae2

Related Issues

Does this pull request have any related issues?

NA

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). labels Aug 22, 2024
@Pranavchiku Pranavchiku marked this pull request as ready for review August 22, 2024 14:14
kgryte
kgryte reviewed Aug 23, 2024
View reviewed changes
lib/node_modules/@stdlib/lapack/base/dlae2/test/test.dlae2.js
var expected;
var out;

out = new Float64Array( 2 );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And just checking: do the various test cases below ensure 100% code coverage?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check, I have not checked yet.

kgryte
kgryte reviewed Aug 23, 2024
View reviewed changes
lib/node_modules/@stdlib/lapack/base/dlae2/test/test.ndarray.js
t.end();
});

tape( 'the function supports complex access pattern to store computed values', function test( t ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tests, always test to the interface, not the implementation. Here, you're doing the latter, taking shortcuts because you know that various accuracy tests are in test.dlae.js. Don't do that. When testing to the interface, you must assume that behind the interface is a separate, independent implementation. That means writing tests which share similarities with other tests for similar interfaces.

kgryte
kgryte requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a first round of comments.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Sep 17, 2024
@kgryte
Copy link
Member

kgryte commented Sep 17, 2024

Looks like the tests still need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranavchiku @kgryte