feat: add lapack/base/dlacn2
#2790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
added
Feature
Pranavchiku
commented
Aug 14, 2024
Pranavchiku
commented
Aug 15, 2024
Comment on lines
+54
to
+60
| - **N**: order of matrix `A`. | ||
| - **V** [`Float64Array`][mdn-float64array], on final return `V=A*W`, where `W` is not returned. | ||
| - **X** input [`Float64Array`][mdn-float64array]. | ||
| - **ISGN** [`Int32Array`][mdn-int32array] of signs. | ||
| - **EST** [`Float64Array`][mdn-float64array] containing estimate of lower bound of 1-norm of `A`. | ||
| - **KASE** [`Int32Array`][mdn-int32array] containing value KASE to control overwritting of `X`. | ||
| - **ISAVE** [`Int32Array`][mdn-int32array] for internal storage. |
There was a problem hiding this comment.
I am not sure about these descriptions.
Pranavchiku
commented
Aug 15, 2024
Pranavchiku
commented
Aug 15, 2024
Pranavchiku
commented
Aug 15, 2024
Pranavchiku
commented
Aug 15, 2024
Signed-off-by: Pranav <[email protected]>
2 tasks
|
I'll add more tests once decision over #2792 is made. Now, working to support negative strides for |
kgryte
reviewed
Aug 15, 2024
kgryte
reviewed
Aug 15, 2024
kgryte
reviewed
Sep 17, 2024
|
|
||
| # dlacn2 | ||
|
|
||
| > Estimate the 1-norm of a square, real matrix `A`, reverse communication is used for evaluating matrix-vector products. |
There was a problem hiding this comment.
This description is hard to read, as "reverse communication..." is a separate clause. This should be improved.
kgryte
reviewed
Sep 17, 2024
| } | ||
| EST[ offsetEST ] = dasum( N, X, strideX, offsetX ); | ||
| for ( i = 0; i < N; i++ ) { | ||
| if ( X[ offsetX + ( i * strideX ) ] >= 0.0 ) { |
There was a problem hiding this comment.
Same comment as in other PRs. Use a tmp variable: ix = offsetX and then ix += strideX. Your implementations consistently have unnecessary flops.
kgryte
added
the
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2464.
Description
This pull request adds JS implementation for
lapack/base/dlacn2.Related Issues
NA
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers