feat: add C implementation for math/base/special/riemann-zeta
#2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planeshifter
added
Ready To Merge
kgryte
reviewed
Aug 3, 2024
lib/node_modules/@stdlib/math/base/special/riemann-zeta/include/stdlib/math/base/special/zeta.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Gunj Joshi <[email protected]>
kgryte
reviewed
Aug 3, 2024
lib/node_modules/@stdlib/math/base/special/riemann-zeta/src/main.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Aug 3, 2024
kgryte
reviewed
Aug 3, 2024
lib/node_modules/@stdlib/math/base/special/riemann-zeta/src/main.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Aug 3, 2024
kgryte
reviewed
Aug 3, 2024
lib/node_modules/@stdlib/math/base/special/riemann-zeta/src/main.c
Outdated
Show resolved
Hide resolved
kgryte
requested changes
Aug 3, 2024
There was a problem hiding this comment.
@Planeshifter This PR needs changes before it can be merged.
kgryte
reviewed
Aug 3, 2024
| @@ -163,7 +163,7 @@ tape( 'the function handles negative integer values which are larger in magnitud | |||
| s = -259; | |||
| v = zeta( s ); | |||
| delta = abs( v - expected ); | |||
| tol = 352.0 * EPS * abs( expected ); | |||
| tol = 656.0 * EPS * abs( expected ); | |||
There was a problem hiding this comment.
Reverted the change; tests still pass.
kgryte
reviewed
Aug 3, 2024
| s = -259; | ||
| v = zeta( s ); | ||
| delta = abs( v - expected ); | ||
| tol = 656.0 * EPS * abs( expected ); |
There was a problem hiding this comment.
Are you able to confirm the source of why the C implementation requires double the tolerance as the JS implementation?
There was a problem hiding this comment.
@kgryte This happens when s = -259, which is near to the overflowing value. There is a minor difference in the results for this, where the c implementation yields 8.760156344624196e+306 while the js implementation gives 8.760156344623199e+306. I've tried logging intermediate values, checking other functions involved, but couldn't find anything. I'll look more into this.
kgryte
reviewed
Aug 3, 2024
lib/node_modules/@stdlib/math/base/special/riemann-zeta/src/main.c
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
Cimplementation formath/base/special/riemann-zeta.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers