Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix incorrect package description in string/left-trim-n #2736

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

Snehil-Shah
Copy link
Member

@Snehil-Shah Snehil-Shah commented Aug 3, 2024

Description

What is the purpose of this pull request?

This pull request:

  • fixes incorrect package description in string/left-trim-n

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@kgryte
Copy link
Member

kgryte commented Aug 3, 2024

@Snehil-Shah You need to actually update the reference package, NOT the namespace README. The namespace README is auto-generated from child package information.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Aug 3, 2024
@Snehil-Shah
Copy link
Member Author

Understood.

@Snehil-Shah Snehil-Shah changed the title docs: fix incorrect package description in string namespace docs: fix incorrect package description in string/left-trim-n Aug 3, 2024
@Snehil-Shah Snehil-Shah requested a review from kgryte August 3, 2024 10:43
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Planeshifter Planeshifter merged commit 7785577 into stdlib-js:develop Aug 3, 2024
8 checks passed
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
PR-URL: stdlib-js#2736

---------

Signed-off-by: Snehil Shah <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants