-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lapack/base/dge-trans
#2734
Conversation
@Pranavchiku Is there a reason to name the package as |
I see, I initially used snake case and it threw me lint error. Also, I am unable to understand sense of |
Is it double precision general matrix transpose? If yes, then it makes sense. |
lapack/base/transpose
lapack/base/dge-trans
Yes, I believe so. Not sure why they didn't do |
lapack/base/dge-trans
lapack/base/dgetrans
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some initial comments.
lapack/base/dgetrans
lapack/base/dge-trans
…/Pranavchiku/2734
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for working on this, @Pranavchiku.
Note that the tests were rather spartan. I would argue it is better to create tests which build on one another, rather than creating a single test which attempts to do all the things. By isolating one behavioral aspect at a time, we can better ensure that an implementation behaves as expected. For combining all the things into one, it can be harder to disentangle which aspect is causing a test to fail.
In principle, we could implement matrix transposition using loop tiling. Loop tiling would only benefit when layout access patterns for |
PR-URL: stdlib-js#2734 Ref: stdlib-js#2464 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
Towards #2464.
Description
This pull request exposes utility function
dge_trans
aslapack/base/dge-trans
.Related Issues
NA
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers