Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/factorialln #2731

Merged
merged 3 commits into from
Aug 3, 2024
Merged

feat: add C implementation for math/base/special/factorialln #2731

merged 3 commits into from
Aug 3, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Aug 3, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_factorialln( const double x );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Aug 3, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Aug 3, 2024
@Planeshifter Planeshifter self-requested a review August 3, 2024 00:45
Planeshifter
Planeshifter approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gunjjoshi!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Aug 3, 2024
@Planeshifter Planeshifter merged commit 1c43f05 into stdlib-js:develop Aug 3, 2024
21 checks passed
@gunjjoshi gunjjoshi deleted the factorialln branch August 11, 2024 10:58
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@gunjjoshi
feat: add C implementation for math/base/special/factorialln
5da2a84 
PR-URL: stdlib-js#2731 
Ref: stdlib-js#649 

Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjjoshi @Planeshifter @stdlib-bot