Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blas/base/dsyr #2659

Merged
merged 11 commits into from
Aug 1, 2024
Merged

feat: add blas/base/dsyr #2659

merged 11 commits into from
Aug 1, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Jul 25, 2024 •
edited
Loading

Progresses #2039.

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to perform the symmetric rank 1 operation A = α*x*x**T + A where α is a scalar, x is an N element vector, and A is an N by N symmetric matrix as defined in BLAS Level 2 routines. Specifically adding @stdlib/blas/base/dsyr is proposed.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Jul 25, 2024
@aman-095 aman-095 added the Needs Review A pull request which needs code review. label Jul 30, 2024
@kgryte
Copy link
Member

kgryte commented Aug 1, 2024

@aman-095 Would you mind replicating the changes from #2658 in this PR? Thanks!

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Aug 1, 2024
@aman-095 aman-095 added the Needs Review A pull request which needs code review. label Aug 1, 2024
kgryte
kgryte approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@kgryte kgryte removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Aug 1, 2024
@kgryte kgryte merged commit 43439d0 into stdlib-js:develop Aug 1, 2024
12 checks passed
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@aman-095 @kgryte @gunjjoshi
feat: add blas/base/dsyr
27f0136 
PR-URL: stdlib-js#2659
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman-095 @kgryte @stdlib-bot