Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/aversin #1731

Merged
merged 2 commits into from
Mar 6, 2024
Merged

feat: add C implementation for math/base/special/aversin #1731

merged 2 commits into from
Mar 6, 2024

Conversation

Snehil-Shah
Copy link
Member

Resolves #1721

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for math/base/special/aversin

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 6, 2024
Pranavchiku
Pranavchiku requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a minor change and it will be ready to merge.

lib/node_modules/@stdlib/math/base/special/aversin/src/main.c Outdated Show resolved Hide resolved
@Pranavchiku Pranavchiku added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 6, 2024
Pranavchiku
Pranavchiku approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Snehil-Shah !

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 6, 2024
@Planeshifter Planeshifter merged commit 8459377 into stdlib-js:develop Mar 6, 2024
7 checks passed
utkrs01 pushed a commit to utkrs01/stdlib that referenced this pull request Mar 7, 2024
@Snehil-Shah @Pranavchiku
feat: add C implementation for math/base/special/aversin
794bf64 
PR-URL: stdlib-js#1731
Closes: stdlib-js#1721

---------

Signed-off-by: Snehil Shah <[email protected]>
Co-authored-by: Pranavchiku <[email protected]>
Reviewed-by: Pranavchiku <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
nishant-s7 pushed a commit to nishant-s7/stdlib that referenced this pull request Mar 7, 2024
@Snehil-Shah @Pranavchiku @nishant-s7
feat: add C implementation for math/base/special/aversin
dc81d3e 
PR-URL: stdlib-js#1731
Closes: stdlib-js#1721

---------

Signed-off-by: Snehil Shah <[email protected]>
Co-authored-by: Pranavchiku <[email protected]>
Reviewed-by: Pranavchiku <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
@Snehil-Shah Snehil-Shah mentioned this pull request Mar 29, 2024
Closed
6 tasks
@Snehil-Shah Snehil-Shah deleted the issue1721-aversin branch April 26, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/aversin
3 participants
@Snehil-Shah @Planeshifter @Pranavchiku