fix: apply code review suggestion

stdlib-js · Oct 11, 2024 · 025112c · 025112c
1 parent 0eae9a9
commit 025112c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/lib/ndarray.js b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/lib/ndarray.js
@@ -53,15 +53,14 @@ function dnannsumors( N, x, strideX, offsetX, out, strideOut, offsetOut ) {
  var n;
  var i;
 
- ix = offsetX;
- io = offsetOut;
-
  sum = 0.0;
+ io = offsetOut;
  if ( N <= 0 ) {
  out[ io ] = sum;
  out[ io+strideOut ] = 0;
  return out;
  }
+ ix = offsetX;
  if ( strideX === 0 ) {
  if ( isnan( x[ ix ] ) ) {
  out[ io ] = sum;

diff --git a/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/src/main.c b/lib/node_modules/@stdlib/blas/ext/base/dnannsumors/src/main.c
@@ -16,8 +16,8 @@
 * limitations under the License.
 */
 
-#include "stdlib/strided/base/stride2offset.h"
 #include "stdlib/blas/ext/base/dnannsumors.h"
+#include "stdlib/strided/base/stride2offset.h"
 #include "stdlib/math/base/assert/is_nan.h"
 #include "stdlib/blas/base/shared.h"
 
@@ -51,11 +51,11 @@ double API_SUFFIX(stdlib_strided_dnannsumors_ndarray)( const CBLAS_INT N, const
  CBLAS_INT i;
 
  sum = 0.0;
- ix = offsetX;
- *n = 0;
  if ( N <= 0 ) {
  return sum;
  }
+ ix = offsetX;
+ *n = 0;
  if ( strideX == 0 ) {
  if ( stdlib_base_is_nan( X[ 0 ] ) ) {
  return sum;