Add remaining metrics for message reliability #64
+325
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adklempner
force-pushed
the
feat/message-reliability
branch
2 times, most recently
from
c7c2c34
to
4dfc180
Compare
vpavlin
reviewed
Oct 1, 2024
| CONSTRAINT dialFailure_unique UNIQUE (recordId, errorType, protocols, timestamp) | ||
| ); | ||
|
|
||
| ALTER TABLE dialFailure ADD CONSTRAINT fk_dialFailure_telemetryRecord |
There was a problem hiding this comment.
Shouldn't there be a foreign key constraint for dial_error_types as well? Just to make sure we don't insert non-existant error types?
vpavlin
reviewed
Oct 1, 2024
| errorMsg TEXT, | ||
| protocols TEXT NOT NULL, | ||
| timestamp INTEGER NOT NULL, | ||
| CONSTRAINT dialFailure_unique UNIQUE (recordId, errorType, protocols, timestamp) |
There was a problem hiding this comment.
I think this one is missing in the test_utils.go cleanup
There was a problem hiding this comment.
It seems to work without it but I added it anyways
vpavlin
approved these changes
Oct 1, 2024
adklempner
force-pushed
the
feat/message-reliability
branch
from
4dfc180
to
5a35627
Compare
adklempner
force-pushed
the
feat/message-reliability
branch
from
5a35627
to
c490c16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following metrics: