[#21615] fix: hide mercuryo provider #21626

mohsen-ghafouri · 2024-11-14T14:20:35Z

fixes #21615

Summary

hide Mercuryo from the list of on-ramp providers
so that we stay compliant with UK law.

Note: it only has status-go changes

Areas that maybe impacted

Ways to buy asset modal

Result

status: ready

status-im-auto · 2024-11-14T14:26:57Z

Jenkins Builds

Click to see older builds (19)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`f20319b`	#1	2024-11-14 14:26:56	~5 min	`tests`	📄`log`
✔️	`f20319b`	#1	2024-11-14 14:30:28	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`f20319b`	#1	2024-11-14 14:31:32	~10 min	`ios`	📱`ipa` 📲
✔️	`f20319b`	#1	2024-11-14 14:32:10	~11 min	`android`	🤖`apk` 📲

✔️	`e5330a5`	#2	2024-11-20 12:13:49	~6 min	`tests`	📄`log`
❌	`e5330a5`	#2	2024-11-20 12:13:58	~7 min	`android-e2e`	📄`log`
❌	`e5330a5`	#2	2024-11-20 12:14:34	~7 min	`ios`	📄`log`
❌	`e5330a5`	#2	2024-11-20 12:15:09	~8 min	`android`	📄`log`
❌	`e5330a5`	#3	2024-11-20 13:43:46	~7 min	`ios`	📄`log`
❌	`e5330a5`	#3	2024-11-20 13:44:29	~3 min	`android`	📄`log`
❌	`e5330a5`	#3	2024-11-20 13:44:51	~3 min	`android-e2e`	📄`log`

✔️	`115ba82`	#3	2024-11-20 14:51:55	~6 min	`tests`	📄`log`
✔️	`115ba82`	#4	2024-11-20 14:54:38	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`115ba82`	#4	2024-11-20 14:55:58	~10 min	`ios`	📱`ipa` 📲
✔️	`115ba82`	#4	2024-11-20 14:56:23	~10 min	`android`	🤖`apk` 📲

✔️	`dadb10b`	#4	2024-11-21 14:23:30	~5 min	`tests`	📄`log`
✔️	`dadb10b`	#5	2024-11-21 14:26:50	~9 min	`ios`	📱`ipa` 📲
✔️	`dadb10b`	#5	2024-11-21 14:27:05	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`dadb10b`	#5	2024-11-21 14:28:01	~10 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`4777713`	#5	2024-11-21 15:46:10	~5 min	`tests`	📄`log`
✔️	`4777713`	#6	2024-11-21 15:49:30	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`4777713`	#6	2024-11-21 15:51:47	~10 min	`android`	🤖`apk` 📲
✔️	`4777713`	#6	2024-11-21 15:53:40	~12 min	`ios`	📱`ipa` 📲

❌	`ad0b7e7`	#6	2024-11-22 10:29:28	~4 min	`tests`	📄`log`
✔️	`ad0b7e7`	#7	2024-11-22 10:32:37	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`ad0b7e7`	#7	2024-11-22 10:33:22	~8 min	`android`	🤖`apk` 📲
✔️	`ad0b7e7`	#7	2024-11-22 10:33:45	~8 min	`ios`	📱`ipa` 📲
✔️	`ad0b7e7`	#7	2024-11-22 11:08:57	~2 min	`tests`	📄`log`

status-im-auto · 2024-11-20T12:24:45Z

62% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 1
Passed tests: 5

IDs of failed tests: 702745,703133

IDs of expected to fail tests: 702843

Failed tests (2)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133

Device 1: Find `Button` by `accessibility id`: `show-profiles`
Device 1: Tap on found: Button

critical/chats/test_public_chat_browsing.py:245: in test_restore_multiaccount_with_waku_backup_remove_profile_switch
    self.errors.verify_no_errors()
base_test_case.py:192: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!

Device sessions

Device 1:

Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device 2: Button element not found
Device 2: Wait for element Button for max 30s and click when it is available

Test setup failed: critical/chats/test_1_1_public_chats.py:24: in prepare_devices
    self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:52: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:249: in create_user
    self.not_now_button.wait_and_click()
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[@text='Not now']` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
`Test is not run, e2e blocker` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

Passed tests (5)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Horupa-Olena · 2024-11-20T13:33:07Z

@mohsen-ghafouri Thanks for your PR!
Could you please resolve the issues with the failed builds?

mohsen-ghafouri · 2024-11-20T14:56:42Z

Hi @Horupa-Olena, all good now.

Horupa-Olena · 2024-11-21T08:45:11Z

@mohsen-ghafouri Thanks for your work!
Since Mercuryo has been hidden from the app, the Recurrent tab is now empty, which doesn’t look great. Could you also hide this tab as part of this PR?

status-im-auto · 2024-11-21T15:36:46Z

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 1
Expected to fail tests: 1
Passed tests: 6

IDs of failed tests: 703133

IDs of expected to fail tests: 702843

Failed tests (1)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133

Device 1: Tap on found: Button
# STEP: Check that removed user is not shown in the list anymore

critical/chats/test_public_chat_browsing.py:240: in test_restore_multiaccount_with_waku_backup_remove_profile_switch
    self.errors.verify_no_errors()
base_test_case.py:192: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!

Device sessions

Device 1:

Steps, video, logs

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
`Test is not run, e2e blocker` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

Passed tests (6)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

mohsen-ghafouri · 2024-11-21T15:41:57Z

Hi @Horupa-Olena, please test again. applied changes.

Horupa-Olena · 2024-11-22T09:44:23Z

@mohsen-ghafouri Thanks for your work!
Please resolve the conflicts so I can start testing.

status-im/status-go@906c50b...2d41745

mohsen-ghafouri · 2024-11-22T10:24:45Z

@Horupa-Olena done

Horupa-Olena · 2024-11-22T13:42:38Z

@mohsen-ghafouri Thank you! Everything looks good.
This PR is ready to be merged.

mohsen-ghafouri self-assigned this Nov 14, 2024

mohsen-ghafouri requested review from vkjr, briansztamfater and smohamedjavid November 14, 2024 14:22

vkjr approved these changes Nov 15, 2024

View reviewed changes

mohsen-ghafouri added the request-manual-qa label Nov 20, 2024

mohsen-ghafouri force-pushed the fix/hide-mercuryo branch from f20319b to e5330a5 Compare November 20, 2024 12:06

VolodLytvynenko self-assigned this Nov 20, 2024

smohamedjavid approved these changes Nov 20, 2024

View reviewed changes

Horupa-Olena assigned Horupa-Olena and unassigned VolodLytvynenko Nov 20, 2024

mohsen-ghafouri force-pushed the fix/hide-mercuryo branch from 115ba82 to dadb10b Compare November 21, 2024 14:17

mohsen-ghafouri added 3 commits November 22, 2024 13:24

[#21615] fix: hide mercuryo provider

ba45ec9

status-im/status-go@906c50b...2d41745

[#21615] chore: update go version

b33437a

[#21615] fix: hide tabs if there is no recurrent data

ad0b7e7

mohsen-ghafouri force-pushed the fix/hide-mercuryo branch from 4777713 to ad0b7e7 Compare November 22, 2024 10:24

Horupa-Olena added the Tested - OK label Nov 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#21615] fix: hide mercuryo provider #21626

[#21615] fix: hide mercuryo provider #21626

mohsen-ghafouri commented Nov 14, 2024 •

edited by vkjr

Loading

status-im-auto commented Nov 14, 2024 •

edited

Loading

status-im-auto commented Nov 20, 2024

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Horupa-Olena commented Nov 20, 2024

mohsen-ghafouri commented Nov 20, 2024

Horupa-Olena commented Nov 21, 2024

status-im-auto commented Nov 21, 2024

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

mohsen-ghafouri commented Nov 21, 2024

Horupa-Olena commented Nov 22, 2024

mohsen-ghafouri commented Nov 22, 2024

Horupa-Olena commented Nov 22, 2024

[#21615] fix: hide mercuryo provider #21626

Are you sure you want to change the base?

[#21615] fix: hide mercuryo provider #21626

Conversation

mohsen-ghafouri commented Nov 14, 2024 • edited by vkjr Loading

Summary

Areas that maybe impacted

Result

status-im-auto commented Nov 14, 2024 • edited Loading

Jenkins Builds

status-im-auto commented Nov 20, 2024

62% of end-end tests have passed

Failed tests (2)

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Expected to fail tests (1)

Class TestCommunityMultipleDeviceMerged:

Passed tests (5)

Class TestWalletMultipleDevice:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Horupa-Olena commented Nov 20, 2024

mohsen-ghafouri commented Nov 20, 2024

Horupa-Olena commented Nov 21, 2024

status-im-auto commented Nov 21, 2024

75% of end-end tests have passed

Failed tests (1)

Class TestCommunityOneDeviceMerged:

Expected to fail tests (1)

Class TestCommunityMultipleDeviceMerged:

Passed tests (6)

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

mohsen-ghafouri commented Nov 21, 2024

Horupa-Olena commented Nov 22, 2024

mohsen-ghafouri commented Nov 22, 2024

Horupa-Olena commented Nov 22, 2024

mohsen-ghafouri commented Nov 14, 2024 •

edited by vkjr

Loading

status-im-auto commented Nov 14, 2024 •

edited

Loading