[#21557] feat: show from account page in swap flow #21611

mohsen-ghafouri · 2024-11-12T10:12:32Z

fixes #21557

Summary

The "From" page should appear, allowing the user to choose the account for the swap.

Areas that maybe impacted

Swap flow when user has multiple account

Steps to test

Ensure user has at least 2 accounts set up.
Go to the wallet main page.
Tap on "Swap" for any asset.

Result

Simulator.Screen.Recording.-.iPhone.13.-.2024-11-13.at.23.25.52.mp4

status: ready

status-im-auto · 2024-11-12T10:18:18Z

Jenkins Builds

Click to see older builds (42)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`d516016`	#1	2024-11-12 10:18:17	~5 min	`tests`	📄`log`
✔️	`d516016`	#1	2024-11-12 10:22:02	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`d516016`	#1	2024-11-12 10:22:20	~9 min	`ios`	📱`ipa` 📲
✔️	`d516016`	#1	2024-11-12 10:22:33	~9 min	`android`	🤖`apk` 📲

✔️	`d730706`	#2	2024-11-13 20:25:04	~4 min	`tests`	📄`log`
✔️	`d730706`	#2	2024-11-13 20:28:56	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`d730706`	#2	2024-11-13 20:29:11	~8 min	`ios`	📱`ipa` 📲
✔️	`d730706`	#2	2024-11-13 20:29:36	~9 min	`android`	🤖`apk` 📲

✔️	`f2900c3`	#3	2024-11-13 20:39:43	~4 min	`tests`	📄`log`
✔️	`f2900c3`	#3	2024-11-13 20:43:55	~8 min	`ios`	📱`ipa` 📲
✔️	`f2900c3`	#3	2024-11-13 20:43:56	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`f2900c3`	#3	2024-11-13 20:44:26	~9 min	`android`	🤖`apk` 📲

✔️	`cddf6c2`	#4	2024-11-19 13:53:19	~4 min	`tests`	📄`log`
✔️	`cddf6c2`	#4	2024-11-19 13:54:59	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`cddf6c2`	#4	2024-11-19 13:56:49	~8 min	`android`	🤖`apk` 📲
✔️	`cddf6c2`	#4	2024-11-19 13:58:02	~9 min	`ios`	📱`ipa` 📲

❌	`b2f6b15`	#5	2024-11-19 14:17:30	~4 min	`tests`	📄`log`
✔️	`b2f6b15`	#6	2024-11-19 14:20:45	~2 min	`tests`	📄`log`
✔️	`b2f6b15`	#5	2024-11-19 14:21:48	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`b2f6b15`	#5	2024-11-19 14:21:55	~9 min	`ios`	📱`ipa` 📲
✔️	`b2f6b15`	#5	2024-11-19 14:22:24	~9 min	`android`	🤖`apk` 📲

✔️	`f83deb5`	#7	2024-11-19 17:34:14	~4 min	`tests`	📄`log`
✔️	`f83deb5`	#6	2024-11-19 17:38:19	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`f83deb5`	#6	2024-11-19 17:38:51	~9 min	`android`	🤖`apk` 📲
✔️	`f83deb5`	#6	2024-11-19 17:40:13	~10 min	`ios`	📱`ipa` 📲

✔️	`e093d42`	#8	2024-11-20 16:06:20	~5 min	`tests`	📄`log`
✔️	`e093d42`	#7	2024-11-20 16:10:48	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`e093d42`	#7	2024-11-20 16:12:15	~11 min	`android`	🤖`apk` 📲
❌	`e093d42`	#7	2024-11-20 16:13:25	~12 min	`ios`	📄`log`

✔️	`9143d15`	#9	2024-11-20 18:40:08	~4 min	`tests`	📄`log`
✔️	`9143d15`	#8	2024-11-20 18:43:59	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`9143d15`	#8	2024-11-20 18:44:42	~9 min	`android`	🤖`apk` 📲
✔️	`9143d15`	#8	2024-11-20 18:47:44	~12 min	`ios`	📱`ipa` 📲

✔️	`cc11a5f`	#10	2024-11-21 15:57:10	~4 min	`tests`	📄`log`
✔️	`cc11a5f`	#9	2024-11-21 15:59:03	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`cc11a5f`	#9	2024-11-21 16:01:05	~8 min	`android`	🤖`apk` 📲
✔️	`cc11a5f`	#10	2024-11-21 17:29:20	~7 min	`android`	🤖`apk` 📲
✔️	`cc11a5f`	#10	2024-11-21 17:31:07	~9 min	`ios`	📱`ipa` 📲

✔️	`95cc78b`	#11	2024-11-21 18:00:20	~4 min	`tests`	📄`log`
✔️	`95cc78b`	#11	2024-11-21 18:04:17	~8 min	`ios`	📱`ipa` 📲
✔️	`95cc78b`	#10	2024-11-21 18:04:25	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`95cc78b`	#11	2024-11-21 18:04:55	~9 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`a234559`	#12	2024-11-22 09:53:08	~6 min	`tests`	📄`log`
✔️	`a234559`	#11	2024-11-22 09:55:34	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`a234559`	#12	2024-11-22 09:56:29	~9 min	`ios`	📱`ipa` 📲
✔️	`a234559`	#12	2024-11-22 09:58:49	~11 min	`android`	🤖`apk` 📲

✔️	`398289a`	#13	2024-11-22 12:58:35	~4 min	`tests`	📄`log`
✔️	`398289a`	#12	2024-11-22 13:00:43	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`398289a`	#13	2024-11-22 13:02:57	~9 min	`android`	🤖`apk` 📲
✔️	`398289a`	#13	2024-11-22 13:04:20	~10 min	`ios`	📱`ipa` 📲

src/status_im/contexts/wallet/common/utils.cljs

src/status_im/contexts/wallet/swap/events.cljs

src/status_im/navigation/screens.cljs

src/status_im/contexts/wallet/swap/events.cljs

status-im-auto · 2024-11-19T14:01:42Z

62% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 1
Passed tests: 5

IDs of failed tests: 727231,740490

IDs of expected to fail tests: 702843

Failed tests (2)

Click to expand

Rerun failed tests

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Test setup failed: critical/test_wallet.py:200: in prepare_devices self.drivers, self.loop = create_shared_drivers(1) base_test_case.py:310: in create_shared_drivers drivers = loop.run_until_complete(start_threads(test_suite_data.current_test.name, /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:26: in start_threads returns[k] = await returns[k] /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/webdriver.py:257: in __init__ super().__init__( ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:206: in __init__ self.start_session(capabilities) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/webdriver.py:346: in start_session response = self.execute(RemoteCommand.NEW_SESSION, w3c_caps) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute self.error_handler.check_response(response) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:229: in check_response raise exception_class(message, screen, stacktrace) Internal Server Error
2. test_wallet_balance_mainnet, id: 740490
Test setup failed: critical/test_wallet.py:200: in prepare_devices self.drivers, self.loop = create_shared_drivers(1) base_test_case.py:310: in create_shared_drivers drivers = loop.run_until_complete(start_threads(test_suite_data.current_test.name, /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:26: in start_threads returns[k] = await returns[k] /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/webdriver.py:257: in __init__ super().__init__( ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:206: in __init__ self.start_session(capabilities) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/webdriver.py:346: in start_session response = self.execute(RemoteCommand.NEW_SESSION, w3c_caps) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute self.error_handler.check_response(response) ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:229: in check_response raise exception_class(message, screen, stacktrace) Internal Server Error

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
`Test is not run, e2e blocker` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

Passed tests (5)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

src/status_im/contexts/wallet/swap/from/view.cljs

src/status_im/subs/wallet/swap.cljs

smohamedjavid · 2024-11-19T14:02:07Z

src/status_im/contexts/wallet/swap/events.cljs

+      :fx (if (and multi-account? (= view-id :wallet-stack) (not from-account))
+            [[:dispatch [:open-modal :screen/wallet.swap-from]]]


Quick question: From reading the code, i can understand that this opens the account selection screen (from) screen if the user has more than one account (any type). This is different in send/bridge flow. Only if the asset is available on multiple accounts, that's when we open the from screen with list of accounts that has that asset.

cc @briansztamfater

Yes, we should open this modal only if the selected asset is in multiple accounts and has any balance on more than one account.

yes it's different according to QA's doc list of test cases

according to design we list all accounts but show account with zero balance with disabled state

here is design link @smohamedjavid @briansztamfater https://www.figma.com/design/AD2JSKg0I8dZcylyiGa62O/Swap-for-Mobile?node-id=1691-48506&m=dev

yeah maybe just condition here has a wrong text, otherwise we have account with zero balance in design.

In the designs three accounts are shown, which two of them have balance, and that's why the third one is disabled. But (from my understanding) if the user has two (or more) accounts and only balance for the selected asset in only one of them, the account selection page should not be shown.

I guess better to check linked issue description, #21557 (comment)

also list of list of test cases

I implemented it accordingly

Implementation looks correct based in the test cases document, I am just wondering if test cases are correctly set, as design implies that the From page should be shown only if asset exist in multiple accounts, but on the document there are some test cases that expect the From page to be always shown if the user has more than one account, no matter if the asset exist on more than one account. I think we should double check test cases. cc @Horupa-Olena

@briansztamfater Thanks for your comments! I’ll review these cases one more time.

Horupa-Olena · 2024-11-19T14:39:21Z

@mohsen-ghafouri Thank you for your PR!
Can I start testing?

mohsen-ghafouri · 2024-11-19T16:00:16Z

Hey @Horupa-Olena yes please, thanks

briansztamfater

Code-wise, it looks good to me!

@Horupa-Olena @pavloburykh, could you check this comment and verify that we are not misrepresenting the expected behavior? Thanks 🙏 #21611 (comment)

pavloburykh · 2024-11-20T08:56:01Z

Code-wise, it looks good to me!

@Horupa-Olena @pavloburykh, could you check this comment and verify that we are not misrepresenting the expected behavior? Thanks 🙏 #21611 (comment)

@briansztamfater @mohsen-ghafouri Thank you, guys!
From my perspective, the expected behavior seems partially incorrect in both the issue description and the referenced test cases.

Here’s what I believe should be the correct behavior:

The FROM page should only appear if more than one account holds the token selected for the swap.

Scenario 1: If the user has two accounts (e.g., Account 1 and Account 2) but the selected token exists only in one of the accounts, the FROM page should not be displayed.
Scenario 2: If the user selects a token present in both accounts, the FROM page should be displayed.
Scenario 3: If the user has more than two accounts, and the selected token is available in some (more than one) but not all accounts, the FROM page should display. Accounts without the selected token should still be listed but appear disabled, as shown in the design reference.

Let me know your thoughts or if we need further alignment! cc @xAlisher

xAlisher · 2024-11-20T09:00:56Z

Looks good to me

pavloburykh · 2024-11-20T09:12:34Z

Looks good to me

thank you @xAlisher

Horupa-Olena · 2024-11-20T09:17:31Z

Code-wise, it looks good to me!
@Horupa-Olena @pavloburykh, could you check this comment and verify that we are not misrepresenting the expected behavior? Thanks 🙏 #21611 (comment)

@briansztamfater @mohsen-ghafouri Thank you, guys! From my perspective, the expected behavior seems partially incorrect in both the issue description and the referenced test cases.

Here’s what I believe should be the correct behavior:

The FROM page should only appear if more than one account holds the token selected for the swap.

Scenario 1: If the user has two accounts (e.g., Account 1 and Account 2) but the selected token exists only in one of the accounts, the FROM page should not be displayed.

Scenario 2: If the user selects a token present in both accounts, the FROM page should be displayed.

Scenario 3: If the user has more than two accounts, and the selected token is available in some but not all accounts, the FROM page should display. Accounts without the selected token should still be listed but appear disabled, as shown in the design reference.

Let me know your thoughts or if we need further alignment! cc @xAlisher

@mohsen-ghafouri @briansztamfater I agree with this behavior. If it’s implemented this way, I will start testing.
What do you think?

mohsen-ghafouri · 2024-11-20T10:22:12Z

Thank you @pavloburykh , could you please correct the description of linked issue and also test case document? as it will be reference for dev and QA.

@Horupa-Olena I need to apply some changes to cover Scenario 1, will let you know once it's ready for review.

pavloburykh · 2024-11-20T10:29:06Z

Thank you @pavloburykh , could you please correct the description of linked issue and also test case document? as it will be reference for dev and QA.

@mohsen-ghafouri I have corrected issue description. Regarding the document , @VolodLytvynenko could you please correct it, as I have View only permissions.

VolodLytvynenko · 2024-11-20T11:30:41Z

Thank you @pavloburykh , could you please correct the description of linked issue and also test case document? as it will be reference for dev and QA.

@mohsen-ghafouri I have corrected issue description. Regarding the document , @VolodLytvynenko could you please correct it, as I have View only permissions.

I just corrected the table thanx

briansztamfater

Thanks for the modifications @mohsen-ghafouri 🚀

mohsen-ghafouri · 2024-11-20T19:05:44Z

Hey @Horupa-Olena, it's ready for test. thanks in advance

status-im-auto · 2024-11-20T19:20:49Z

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 1
Passed tests: 7

IDs of expected to fail tests: 702843

Expected to fail tests (1)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
`Test is not run, e2e blocker` [[reason: [NOTRUN] Skipped due to waku issue on staging fleet]]

Passed tests (7)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Horupa-Olena · 2024-11-21T15:15:38Z

@mohsen-ghafouri Thanks for your work!

Unfortunately, I’m unable to trigger the From page.

I restored a profile using a seed phrase that had two accounts with assets.
I also tried to trigger the From page on a profile with two empty accounts and two imported accounts with funds. Both attempts were unsuccessful on Android and iOS.

Could you please take a look and check what might be wrong? Let me know if logs are needed.

mohsen-ghafouri · 2024-11-21T15:37:21Z

Hey @Horupa-Olena, a video of test would be helpful, as you can see in my last comment the result with my account is like this #21611 (comment)

swap with account that has balance worked fine for my accounts

mohsen-ghafouri · 2024-11-21T15:53:00Z

Just retest it with latest changes, the result is the same, you should have an asset available at least in 2 accounts to see the "From" page in swap flow
CC @Horupa-Olena

scenarios #21611 (comment)

Simulator.Screen.Recording.-.iPhone.13.-.2024-11-21.at.18.51.09.mp4

Horupa-Olena · 2024-11-21T16:19:00Z

@mohsen-ghafouri Sorry, I rushed to switch to another task and seem to have sent the comment without waiting for the video to upload.
Here’s the video.

Screenrecorder-2024-11-21-18-15-29-966.mp4

Horupa-Olena · 2024-11-21T16:27:13Z

Just retest it with latest changes, the result is the same, you should have an asset available at least in 2 accounts to see the "From" page in swap flow CC @Horupa-Olena

scenarios #21611 (comment)

Simulator.Screen.Recording.-.iPhone.13.-.2024-11-21.at.18.51.09.mp4

@mohsen-ghafouri I retest on last build. The same result.

ISSUE 1: From page not appears for multichain account

Step

Restore user profile by seed phrase
Turn off test network -> Log out
Log in
Add second acc in wallet
Longtap on ETH on owerview in wallet

Expected results:
Form page appears and allow chose account for swap

Actual results:
Form page not appears

video_2024-11-21_18-26-56.mp4

VolodLytvynenko · 2024-11-21T17:42:29Z

Hi @mohsen-ghafouri, I am also reproducing the issue on the latest builds of current PR. I’ve tried two different users with varying numbers of accounts, some with more than three accounts holding assets. However, I am still unable to see the FROM page:

FROM.mp4

Devices:

Pixel 7a, Android 13
iPhone 11 Pro Max, IOS 17
Android Studion: Pixel XL API 33

mohsen-ghafouri · 2024-11-21T17:56:49Z

I might find the source if issue, it can't detect the root screen, i guess if you switch between tabs and then click on wallet tab it will start working, I just pushed a fix. will test and let you know if it's ready.
CC @Horupa-Olena @VolodLytvynenko

mohsen-ghafouri · 2024-11-21T18:24:07Z

All looks good now, in latest PR's build on my iPhone device, please test and let me know @Horupa-Olena . thanks

2024-11-21.21.22.23.mp4

Horupa-Olena · 2024-11-22T12:00:06Z

@mohsen-ghafouri Thanks for your fix! Everything is finally working.

screen-20241122-135719.mp4

However, I can’t fully test the entire flow and verify that the assets are swapped on the correct account (chosen on the From page) because there’s a bug in the swap flow. I’m waiting for this PR to resolve the issue.

I’d greatly appreciate it if you could also take a look at this issue next, as it’s related to the Swap flow and makes sense to address after fixing the problem with the From page.

Horupa-Olena · 2024-11-22T12:00:56Z

@mohsen-ghafouri You can merge it PR.

mohsen-ghafouri · 2024-11-22T13:14:12Z

Hey @Horupa-Olena thank you for testing this PR, sure i will try to check that as well

mohsen-ghafouri self-assigned this Nov 12, 2024

mohsen-ghafouri force-pushed the fix/from-page-swap branch from d516016 to d730706 Compare November 13, 2024 20:19

mohsen-ghafouri marked this pull request as ready for review November 13, 2024 20:28

mohsen-ghafouri requested review from vkjr, briansztamfater and smohamedjavid November 13, 2024 20:29

mohsen-ghafouri force-pushed the fix/from-page-swap branch from d730706 to f2900c3 Compare November 13, 2024 20:34

vkjr reviewed Nov 19, 2024

View reviewed changes

src/status_im/contexts/wallet/common/utils.cljs Outdated Show resolved Hide resolved

vkjr approved these changes Nov 19, 2024

View reviewed changes

mohsen-ghafouri force-pushed the fix/from-page-swap branch from f2900c3 to cddf6c2 Compare November 19, 2024 13:48

mohsen-ghafouri added the request-manual-qa label Nov 19, 2024

briansztamfater reviewed Nov 19, 2024

View reviewed changes

src/status_im/contexts/wallet/swap/events.cljs Outdated Show resolved Hide resolved

Horupa-Olena self-assigned this Nov 19, 2024

briansztamfater reviewed Nov 19, 2024

View reviewed changes

src/status_im/navigation/screens.cljs Outdated Show resolved Hide resolved

briansztamfater reviewed Nov 19, 2024

View reviewed changes

src/status_im/contexts/wallet/swap/events.cljs Outdated Show resolved Hide resolved

smohamedjavid reviewed Nov 19, 2024

View reviewed changes

mohsen-ghafouri force-pushed the fix/from-page-swap branch from cddf6c2 to b2f6b15 Compare November 19, 2024 14:12

mohsen-ghafouri force-pushed the fix/from-page-swap branch from b2f6b15 to f83deb5 Compare November 19, 2024 17:29

briansztamfater approved these changes Nov 19, 2024

View reviewed changes

briansztamfater approved these changes Nov 20, 2024

View reviewed changes

Horupa-Olena added the Tested - Issues label Nov 21, 2024

mohsen-ghafouri force-pushed the fix/from-page-swap branch from 9143d15 to cc11a5f Compare November 21, 2024 15:51

mohsen-ghafouri force-pushed the fix/from-page-swap branch from cc11a5f to 95cc78b Compare November 21, 2024 17:55

Horupa-Olena force-pushed the fix/from-page-swap branch from 95cc78b to a234559 Compare November 22, 2024 09:46

Horupa-Olena added Tested - OK test cases added and removed Tested - Issues labels Nov 22, 2024

mohsen-ghafouri added 6 commits November 22, 2024 15:52

[#21557] feat: show from account page in swap flow

54ea6ae

[#21557] feat: add disabled state to account-item

fa219ec

[#21557] fix: apply suggestion

6d5c929

[#21557] fix: add format address util and rename screen

18f8af5

[#21557] fix: check and count account with token balance

dbc96ad

[#21557] fix: check for root screen

398289a

mohsen-ghafouri force-pushed the fix/from-page-swap branch from a234559 to 398289a Compare November 22, 2024 12:53

mohsen-ghafouri merged commit 21c2a52 into develop Nov 22, 2024
5 checks passed

mohsen-ghafouri deleted the fix/from-page-swap branch November 22, 2024 13:12

		:fx (if (and multi-account? (= view-id :wallet-stack) (not from-account))
		[[:dispatch [:open-modal :screen/wallet.swap-from]]]

[#21557] feat: show from account page in swap flow #21611

[#21557] feat: show from account page in swap flow #21611

Conversation

mohsen-ghafouri commented Nov 12, 2024 • edited Loading

Summary

Areas that maybe impacted

Steps to test

Result

status-im-auto commented Nov 12, 2024 • edited Loading

Jenkins Builds

status-im-auto commented Nov 19, 2024

62% of end-end tests have passed

Failed tests (2)

Class TestWalletOneDevice:

Expected to fail tests (1)

Class TestCommunityMultipleDeviceMerged:

Passed tests (5)

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

smohamedjavid Nov 19, 2024

Choose a reason for hiding this comment

briansztamfater Nov 19, 2024

Choose a reason for hiding this comment

mohsen-ghafouri Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

mohsen-ghafouri Nov 19, 2024

Choose a reason for hiding this comment

mohsen-ghafouri Nov 19, 2024

Choose a reason for hiding this comment

mohsen-ghafouri Nov 19, 2024

Choose a reason for hiding this comment

briansztamfater Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

mohsen-ghafouri Nov 19, 2024

Choose a reason for hiding this comment

briansztamfater Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

Horupa-Olena Nov 20, 2024

Choose a reason for hiding this comment

Horupa-Olena commented Nov 19, 2024

mohsen-ghafouri commented Nov 19, 2024 • edited Loading

briansztamfater left a comment

Choose a reason for hiding this comment

pavloburykh commented Nov 20, 2024 • edited Loading

xAlisher commented Nov 20, 2024

pavloburykh commented Nov 20, 2024

Horupa-Olena commented Nov 20, 2024

mohsen-ghafouri commented Nov 20, 2024

pavloburykh commented Nov 20, 2024

VolodLytvynenko commented Nov 20, 2024

briansztamfater left a comment

Choose a reason for hiding this comment

mohsen-ghafouri commented Nov 20, 2024

status-im-auto commented Nov 20, 2024

88% of end-end tests have passed

Expected to fail tests (1)

Class TestCommunityMultipleDeviceMerged:

Passed tests (7)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

Horupa-Olena commented Nov 21, 2024

mohsen-ghafouri commented Nov 21, 2024 • edited Loading

mohsen-ghafouri commented Nov 21, 2024 • edited Loading

Horupa-Olena commented Nov 21, 2024

Horupa-Olena commented Nov 21, 2024

VolodLytvynenko commented Nov 21, 2024

Devices:

mohsen-ghafouri commented Nov 21, 2024

mohsen-ghafouri commented Nov 21, 2024

Horupa-Olena commented Nov 22, 2024

Horupa-Olena commented Nov 22, 2024

mohsen-ghafouri commented Nov 22, 2024

mohsen-ghafouri commented Nov 12, 2024 •

edited

Loading

status-im-auto commented Nov 12, 2024 •

edited

Loading

mohsen-ghafouri Nov 19, 2024 •

edited

Loading

briansztamfater Nov 19, 2024 •

edited

Loading

briansztamfater Nov 19, 2024 •

edited

Loading

mohsen-ghafouri commented Nov 19, 2024 •

edited

Loading

pavloburykh commented Nov 20, 2024 •

edited

Loading

mohsen-ghafouri commented Nov 21, 2024 •

edited

Loading

mohsen-ghafouri commented Nov 21, 2024 •

edited

Loading