-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update create profile and sign in screen #21609
Conversation
Jenkins BuildsClick to see older builds (30)
|
7ede4f9
to
b53cab5
Compare
b53cab5
to
55c2c35
Compare
0% of end-end tests have passed
Failed tests (7)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
Expected to fail tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking: @Parveshdhull, are the PNGs compressed?
src/status_im/contexts/onboarding/create_or_sync_profile/view.cljs
Outdated
Show resolved
Hide resolved
Thank you @ilmotta for reviewing the PR. Yes, PNGs are compressed. |
hi @ilmotta I’m a bit unclear about the expected results and would like to clarify a few points if my verification is correct:
However, by design I see "Log in" instead of "Sign in". Screen from the the latest build of current PR
However, in the new design and in the latest build, "recovery phrase" is still used. I understand the design might have been updated, which could cause discrepancies. To confirm: |
hi @yevh-berdnyk Could you please adjust the e2e tests in this PR? It seems the accessibility ID use-recovery-phrase-option-card is no longer used. thanx! |
Hi, @VolodLytvynenko, Thank you very much for taking the PR for testing. Please use latest design (Simplified Onboarding) as source for comparison. Issue content is little outdated.
|
@Parveshdhull thank you for clarification. One more question: Is it expected to see the "Feature not implemented" alert when selecting Use an empty Keycard during profile creation? From my discussion with @mariia-skrypnyk, it seems onboarding with an empty Keycard is available and enabled in the latest nightly. Could you clarify why it’s disabled in the PR? |
Hi @flexsurfer, @ilmotta, Is the implementation of the empty key-card flow complete? Also, should both |
62% of end-end tests have passed
Failed tests (2)Click to expandClass TestWalletMultipleDevice:
Expected to fail tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
Hi @Parveshdhull, @VolodLytvynenko, E2E tests are updated, the recent failures are not PR related. Thanks! |
@Parveshdhull, @VolodLytvynenko, the PR to support the empty keycard flow is in progress #21623. @Parveshdhull I think it's up to you and @flexsurfer to decide who merges first and then the other adjust/rebase. |
Thank you @ilmotta for confirming. Hi @VolodLytvynenko, Since the 'Use Empty Keycard' flow is still under development, let's keep the 'Feature Not Implemented' popup for now. We can update it later as needed. |
@Parveshdhull agree. thank you for your work. PR can be merged! |
99891f4
to
6ec307a
Compare
fixes #21565
fixes #21564
Testing
Please update the e2e tests(if needed) and perform a light check for regressions in above screen.
Note: The content of the info buttons is out of scope.
status: ready