You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the usage of deprecated wallet_filterActivityAsync RPC and updates it to wallet_startActivityFilterSessionV2 with other supporting activity filter session RPCs
Removes deprecated wallet_checkRecentHistoryForChainIDs RPC as we no longer support past transaction history
Added support for Bridge, Swap and Approval activities
Added support for viewing, copying and sharing links to TX details on block explorer
Activities.mp4
Review notes
This PR will be open to review or testing once we move to the new transaction RPC flow, as the activities depend on it.
Testing notes
The activities are shown only for the accounts where the activity originated from
Platforms
Android
iOS
Steps to test
Prerequisites: A wallet account with some tokens
Open Status
Navigate to the Wallet tab
Perform a Send transaction
Verify the transaction is shown in the activity tab
Perform a Bridge transaction
Verify the transaction is shown in the activity tab
Perform a Swap transaction
Verify the transaction is shown in the activity tab (If approval is done, verify it's shown as well)
Verify all the transaction shows options to view, copy, and share the TX details in respective block explorer
This PR will be open to review or testing once we move to the new transaction RPC flow, as the activities depend on it.
how do they depend on it? the transaction RPC flow is basically about send, swap, bridge transactions — it doesn't affect how the filtering of activities is done
This PR will be open to review or testing once we move to the new transaction RPC flow, as the activities depend on it.
how do they depend on it? the transaction RPC flow is basically about send, swap, bridge transactions — it doesn't affect how the filtering of activities is done
@alwx - The new activities we will integrate into the client are locally generated by status-go in the latest transaction RPCs/Flow, not in the deprecated ones we use now.
smohamedjavid
changed the title
[WIP] Wallet Activity: Remove deprecated RPCs and use activity filter session RPC
[WIP] Wallet Activity: A more reliable update
Nov 22, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smohamedjavid
force-pushed
the
chore/activity-rpc-cleanup
branch
from
mohsen-ghafouri
force-pushed
the
chore/activity-rpc-cleanup
branch
from
fixes #21583
Summary
This PR:
wallet_filterActivityAsyncRPC and updates it towallet_startActivityFilterSessionV2with other supporting activity filter session RPCswallet_checkRecentHistoryForChainIDsRPC as we no longer support past transaction historyActivities.mp4
Review notes
This PR will be open to review or testing once we move to the new transaction RPC flow, as the activities depend on it.
Testing notes
The activities are shown only for the accounts where the activity originated from
Platforms
Steps to test
Prerequisites: A wallet account with some tokens
status: WIP